Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow override of OPENTRONS_PROJECT in br #13176

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

sfoster1
Copy link
Member

This will let us optionally build non-full-release builds.

@sfoster1 sfoster1 requested review from a team as code owners July 27, 2023 14:33
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #13176 (d748bef) into internal-release_0.14.0 (9f29c9d) will increase coverage by 0.04%.
Report is 2 commits behind head on internal-release_0.14.0.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           internal-release_0.14.0   #13176      +/-   ##
===========================================================
+ Coverage                    72.53%   72.57%   +0.04%     
===========================================================
  Files                         2394     2365      -29     
  Lines                        66062    65184     -878     
  Branches                      7342     7184     -158     
===========================================================
- Hits                         47915    47307     -608     
+ Misses                       16401    16139     -262     
+ Partials                      1746     1738       -8     
Flag Coverage Δ
app 71.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 45 files with indirect coverage changes

@sfoster1
Copy link
Member Author

@sfoster1 sfoster1 changed the base branch from edge to internal-release_0.14.0 July 27, 2023 16:29
@sfoster1 sfoster1 requested a review from a team as a code owner July 27, 2023 16:29
@sfoster1 sfoster1 requested review from jerader and removed request for a team July 27, 2023 16:29
This will let us optionally build non-full-release builds.
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfoster1 sfoster1 merged commit 74448b1 into internal-release_0.14.0 Jul 27, 2023
70 checks passed
@sfoster1 sfoster1 deleted the ot2-ir-fixes branch July 27, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants