-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): improve labware movement code #13174
refactor(api): improve labware movement code #13174
Conversation
…d labware movement to use motion planning
Codecov Report
@@ Coverage Diff @@
## internal-release_0.14.0 #13174 +/- ##
===========================================================
+ Coverage 72.53% 72.59% +0.05%
===========================================================
Files 2359 2372 +13
Lines 64994 65408 +414
Branches 7213 7209 -4
===========================================================
+ Hits 47143 47482 +339
- Misses 16105 16181 +76
+ Partials 1746 1745 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
I think removing the home commands should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Discussed in-person: we'll QA the home()
vs. move_to()
thing.
Tested moving labware between all modules and deck on a QA bot and it worked exactly the same as before the change. |
Overview
Last refactoring (ish) PR before I add the contextual gripper offsets. This makes updating the code much easier!
Test Plan
Changelog
move_to
to the gripper Z home position. See RLAB-215 for more info. With RLAB-211 fixed, there doesn't seem to be a need to issue a home command before moving to gripper Z each timeReview requests
Risk assessment
Low since tests