Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Protocol-designer, components, step-generation): multi tiprack support #13166

Closed
wants to merge 12 commits into from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jul 25, 2023

Closes RAUT-507

Overview

🔈 This is blocked until post-7.0 PD release 🔈

This PR introduces multi tiprack support in PD. During file creation, you can select up to 3 tipracks per pipette and edit them in the edit pipettes area. On the timeline, the compound command creators related to moving liquid (mix, consolidate, distribute, and transfer) now have a tiprack dropdown to specify which tip you want to use. If you don't select a tip, an error creator will show up telling you a tip is missing

Test Plan

Changelog

  • allow for multi tipracks in CreateFileWizard and PipetteFields, update tests
  • create TiprackField component for a dropdown in the liquid compound command creator forms
  • create a new arg TipRack
  • update pipetteTiprackAssignments type from string to string[] and add that change to the migration
  • update affected tests

Review requests

Is my approach in supporting multi tipracks correct? I changed the pipetteTiprackAssignments key value from a string to a string[]. This change shoudn't affect anything outside of PD since the pipetteTiprackAssignments key is only part of designerApplication in the schema.

Risk assessment

low

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #13166 (68d6373) into edge (fc2ffdb) will increase coverage by 0.00%.
Report is 52 commits behind head on edge.
The diff coverage is 52.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##             edge   #13166     +/-   ##
=========================================
  Coverage   72.08%   72.08%             
=========================================
  Files        1530     1570     +40     
  Lines       50741    51867   +1126     
  Branches     3144     3293    +149     
=========================================
+ Hits        36576    37388    +812     
- Misses      13657    13957    +300     
- Partials      508      522     +14     
Flag Coverage Δ
app 43.93% <ø> (ø)
components 62.94% <0.00%> (-1.56%) ⬇️
labware-library 49.17% <ø> (-0.35%) ⬇️
protocol-designer 47.23% <51.61%> (-0.06%) ⬇️
shared-data 78.18% <ø> (-1.17%) ⬇️
step-generation 86.81% <68.42%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
components/src/instrument/InfoItem.tsx 66.66% <0.00%> (-33.34%) ⬇️
components/src/instrument/InstrumentInfo.tsx 42.85% <0.00%> (-17.15%) ⬇️
...onents/StepEditForm/fields/DisposalVolumeField.tsx 19.04% <ø> (ø)
...tepEditForm/fields/PathField/getDisabledPathMap.ts 0.00% <0.00%> (ø)
.../components/StepEditForm/fields/PathField/index.ts 20.00% <ø> (ø)
...ents/StepEditForm/fields/StepFormDropdownField.tsx 16.66% <ø> (ø)
...gner/src/components/StepEditForm/forms/MixForm.tsx 100.00% <ø> (ø)
...nents/StepEditForm/forms/MoveLabwareForm/index.tsx 0.00% <ø> (ø)
...onents/StepEditForm/forms/MoveLiquidForm/index.tsx 0.00% <ø> (ø)
...r/src/components/modals/EditPipettesModal/index.ts 7.40% <0.00%> (-0.44%) ⬇️
... and 35 more

... and 56 files with indirect coverage changes

@jerader jerader added the blocked Ticket or PR is blocked by other work label Jul 28, 2023
@jerader
Copy link
Collaborator Author

jerader commented Aug 22, 2023

Closing but keeping the branch open for when multi tiprack support is implemented in the future

@jerader jerader closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket or PR is blocked by other work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant