-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Protocol-designer, components, step-generation): multi tiprack support #13166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #13166 +/- ##
=========================================
Coverage 72.08% 72.08%
=========================================
Files 1530 1570 +40
Lines 50741 51867 +1126
Branches 3144 3293 +149
=========================================
+ Hits 36576 37388 +812
- Misses 13657 13957 +300
- Partials 508 522 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closing but keeping the branch open for when multi tiprack support is implemented in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RAUT-507
Overview
🔈 This is blocked until post-7.0 PD release 🔈
This PR introduces multi tiprack support in PD. During file creation, you can select up to 3 tipracks per pipette and edit them in the edit pipettes area. On the timeline, the compound command creators related to moving liquid (
mix
,consolidate
,distribute
, andtransfer
) now have a tiprack dropdown to specify which tip you want to use. If you don't select a tip, an error creator will show up telling you a tip is missingTest Plan
Changelog
CreateFileWizard
andPipetteFields
, update testsTiprackField
component for a dropdown in the liquid compound command creator formsTipRack
pipetteTiprackAssignments
type from string to string[] and add that change to the migrationReview requests
Is my approach in supporting multi tipracks correct? I changed the
pipetteTiprackAssignments
key value from astring
to astring[]
. This change shoudn't affect anything outside of PD since thepipetteTiprackAssignments
key is only part ofdesignerApplication
in the schema.Risk assessment
low