chore: parse tags in utf8 explicitly in python #13163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we parse tags, we didn't explicitly set a codec for parsing the bytes. This is fine in most cases because the locale is set for utf-8, but in the docker container that builds buildroot the locale is C and that means ascii and that means that any tags that have utf-8 characters cause builds to fail.
Codecov Report
@@ Coverage Diff @@
## edge #13163 +/- ##
==========================================
+ Coverage 72.53% 72.59% +0.05%
==========================================
Files 2359 2395 +36
Lines 64994 66082 +1088
Branches 7213 7369 +156
==========================================
+ Hits 47143 47969 +826
- Misses 16105 16353 +248
- Partials 1746 1760 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
vegano1
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we parse tags, we didn't explicitly set a codec for parsing the bytes. This is fine in most cases because the locale is set for utf-8, but in the docker container that builds buildroot the locale is C and that means ascii and that means that any tags that have utf-8 characters cause builds to fail.