fix(api): add yocto to architectures that observe the disabledLogAggregation setting #13132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egation setting Add the advanced setting for disabled log aggregation for yocto system architecture. Closes RSS-289
Codecov Report
@@ Coverage Diff @@
## edge #13132 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 2353 2353
Lines 64902 64902
Branches 7188 7188
=======================================
Hits 47040 47040
Misses 16123 16123
Partials 1739 1739
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SyntaxColoring
approved these changes
Jul 20, 2023
sanni-t
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Verified that the Log aggregation setting becomes available on the flex with this branch.
You probably already know this but just wanted to note this somewhere that it doesn't actually update the log settings on the robot yet because syslog doesn't seem to set up for sending the logs upstream yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the advanced setting for disabled log aggregation for yocto system architecture.
Closes RSS-289
Risk assessment
low