-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(api): simulate not logging drop_tip with no args (#14606)
# Overview Fixes [RESC-214](https://opentrons.atlassian.net/browse/RESC-214) # Test Plan - [x] Add simulate test that runs a protocol using `drop_tip` with no args # Changelog - Add publisher.publish_context context manager when calling drop tip with no args - Add above test case to `test_simulate.py` # Review requests - It seems that the simulate drop tip functionality could benefit from more robust test coverage. Should make sure that we validate all branches inside of drop_tip. But is this PR the place to do it? # Risk assessment Very low. Just added a message and a test [RESC-214]: https://opentrons.atlassian.net/browse/RESC-214?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
- Loading branch information
1 parent
0b40719
commit fb23b41
Showing
3 changed files
with
29 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from opentrons import protocol_api | ||
|
||
requirements = {"robotType": "OT-2", "apiLevel": "2.16"} | ||
|
||
|
||
def run(ctx: protocol_api.ProtocolContext) -> None: | ||
tipracks = [ctx.load_labware("opentrons_96_tiprack_300ul", "5")] | ||
m300 = ctx.load_instrument("p300_multi_gen2", "right", tipracks) | ||
|
||
m300.pick_up_tip() | ||
m300.drop_tip() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters