refactor(api): Hide implementation details from absorbance reader res…

…ults (#16359)
Opentrons · Sep 26, 2024 · edb51fd · edb51fd
1 parent 8d6ff9b
commit edb51fd
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 38 deletions.
diff --git a/api/src/opentrons/protocol_engine/commands/absorbance_reader/__init__.py b/api/src/opentrons/protocol_engine/commands/absorbance_reader/__init__.py
@@ -1,5 +1,4 @@
 """Command models for Absorbance Reader commands."""
-from .types import MoveLidResult
 from .close_lid import (
     CloseLidCommandType,
     CloseLidParams,

diff --git a/api/src/opentrons/protocol_engine/commands/absorbance_reader/close_lid.py b/api/src/opentrons/protocol_engine/commands/absorbance_reader/close_lid.py
@@ -11,7 +11,6 @@
 from opentrons.protocol_engine.types import AddressableAreaLocation
 
 from opentrons.protocol_engine.resources import labware_validation
-from .types import MoveLidResult
 from ...state.update_types import StateUpdate
 
 
@@ -34,7 +33,7 @@ class CloseLidParams(BaseModel):
     moduleId: str = Field(..., description="Unique ID of the absorbance reader.")
 
 
-class CloseLidResult(MoveLidResult):
+class CloseLidResult(BaseModel):
     """Result data from closing the lid on an aborbance reading."""
 
 
@@ -142,9 +141,7 @@ async def execute(
         )
 
         return SuccessData(
-            public=CloseLidResult(
-                lidId=loaded_lid.id, newLocation=new_location, offsetId=new_offset_id
-            ),
+            public=CloseLidResult(),
             private=None,
             state_update=state_update,
         )

diff --git a/api/src/opentrons/protocol_engine/commands/absorbance_reader/open_lid.py b/api/src/opentrons/protocol_engine/commands/absorbance_reader/open_lid.py
@@ -9,7 +9,6 @@
 from ...errors.error_occurrence import ErrorOccurrence
 from ...errors import CannotPerformModuleAction
 
-from .types import MoveLidResult
 from opentrons.protocol_engine.resources import labware_validation
 from opentrons.protocol_engine.types import AddressableAreaLocation
 
@@ -35,7 +34,7 @@ class OpenLidParams(BaseModel):
     moduleId: str = Field(..., description="Unique ID of the absorbance reader.")
 
 
-class OpenLidResult(MoveLidResult):
+class OpenLidResult(BaseModel):
     """Result data from opening the lid on an aborbance reading."""
 
 
@@ -137,11 +136,7 @@ async def execute(self, params: OpenLidParams) -> SuccessData[OpenLidResult, Non
         )
 
         return SuccessData(
-            public=OpenLidResult(
-                lidId=loaded_lid.id,
-                newLocation=new_location,
-                offsetId=new_offset_id,
-            ),
+            public=OpenLidResult(),
             private=None,
             state_update=state_update,
         )

diff --git a/api/src/opentrons/protocol_engine/commands/absorbance_reader/types.py b/api/src/opentrons/protocol_engine/commands/absorbance_reader/types.py