Skip to content

Commit

Permalink
api(src): update deprecated code
Browse files Browse the repository at this point in the history
  • Loading branch information
ahiuchingau committed Apr 10, 2024
1 parent afa2657 commit e83d1b5
Show file tree
Hide file tree
Showing 13 changed files with 37 additions and 31 deletions.
4 changes: 2 additions & 2 deletions api/src/opentrons/calibration_storage/deck_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ def serialize_deck_configuration(
cutout_fixture_placements: List[CutoutFixturePlacement], last_modified: datetime
) -> bytes:
"""Serialize a deck configuration for storing on the filesystem."""
data = _DeckConfigurationModel.construct(
data = _DeckConfigurationModel.model_construct(
cutoutFixtures=[
_CutoutFixturePlacementModel.construct(
_CutoutFixturePlacementModel.model_construct(
cutoutId=e.cutout_id, cutoutFixtureId=e.cutout_fixture_id
)
for e in cutout_fixture_placements
Expand Down
8 changes: 4 additions & 4 deletions api/src/opentrons/cli/analyze.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,18 @@ async def _analyze(
)
analysis = await runner.run(deck_configuration=[], protocol_source=protocol_source)
if json_output:
results = AnalyzeResults.construct(
results = AnalyzeResults.model_construct(
createdAt=datetime.now(tz=timezone.utc),
files=[
ProtocolFile.construct(name=f.path.name, role=f.role)
ProtocolFile.model_construct(name=f.path.name, role=f.role)
for f in protocol_source.files
],
config=(
JsonConfig.construct(
JsonConfig.model_construct(
schemaVersion=protocol_source.config.schema_version
)
if isinstance(protocol_source.config, JsonProtocolConfig)
else PythonConfig.construct(
else PythonConfig.model_construct(
apiVersion=protocol_source.config.api_version
)
),
Expand Down
2 changes: 2 additions & 0 deletions api/src/opentrons/protocol_engine/commands/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
Command,
CommandParams,
CommandCreate,
CommandCreateAdatper,
CommandResult,
CommandType,
CommandPrivateResult,
Expand Down Expand Up @@ -321,6 +322,7 @@
"Command",
"CommandParams",
"CommandCreate",
"CommandCreateAdatper",
"CommandResult",
"CommandType",
"CommandPrivateResult",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ async def execute(self, params: CalibrateGripperParams) -> CalibrateGripperResul
)
calibration_data = result

return CalibrateGripperResult.construct(
jawOffset=Vec3f.construct(
return CalibrateGripperResult.model_construct(
jawOffset=Vec3f.model_construct(
x=probe_offset.x, y=probe_offset.y, z=probe_offset.z
),
savedCalibration=calibration_data,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ async def execute(self, params: CalibratePipetteParams) -> CalibratePipetteResul

await ot3_api.save_instrument_offset(mount=ot3_mount, delta=pipette_offset)

return CalibratePipetteResult.construct(
pipetteOffset=InstrumentOffsetVector.construct(
return CalibratePipetteResult.model_construct(
pipetteOffset=InstrumentOffsetVector.model_construct(
x=pipette_offset.x, y=pipette_offset.y, z=pipette_offset.z
)
)
Expand Down
7 changes: 6 additions & 1 deletion api/src/opentrons/protocol_engine/commands/command_unions.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from typing import Union, TypeVar
from typing_extensions import Annotated

from pydantic import Field
from pydantic import Field, TypeAdapter

from . import heater_shaker
from . import magnetic_module
Expand Down Expand Up @@ -542,6 +542,11 @@
Field(discriminator="commandType"),
]

# Each time a TypeAdapter is instantiated, it will construct a new validator and
# serializer. To improve performance, TypeAdapters are instantiated once.
# See https://docs.pydantic.dev/latest/concepts/performance/#typeadapter-instantiated-once
CommandCreateAdatper: TypeAdapter[CommandCreate] = TypeAdapter(CommandCreate) # type: ignore[arg-type]

CommandResult = Union[
AspirateResult,
AspirateInPlaceResult,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def from_failed(
wrappedErrors = [
cls.from_failed(id, createdAt, err) for err in error.wrapping
]
return cls.construct(
return cls(
id=id,
createdAt=createdAt,
errorType=type(error).__name__,
Expand Down
18 changes: 9 additions & 9 deletions api/src/opentrons/protocol_engine/slot_standardization.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ def standardize_labware_offset(
original: LabwareOffsetCreate, robot_type: RobotType
) -> LabwareOffsetCreate:
"""Convert the deck slot in the given `LabwareOffsetCreate` to match the given robot type."""
return original.copy(
return original.model_copy(
update={
"location": original.location.copy(
"location": original.location.model_copy(
update={
"slotName": original.location.slotName.to_equivalent_for_robot_type(
robot_type
Expand Down Expand Up @@ -70,40 +70,40 @@ def standardize_command(
def _standardize_load_labware(
original: commands.LoadLabwareCreate, robot_type: RobotType
) -> commands.LoadLabwareCreate:
params = original.params.copy(
params = original.params.model_copy(
update={
"location": _standardize_labware_location(
original.params.location, robot_type
)
}
)
return original.copy(update={"params": params})
return original.model_copy(update={"params": params})


def _standardize_load_module(
original: commands.LoadModuleCreate, robot_type: RobotType
) -> commands.LoadModuleCreate:
params = original.params.copy(
params = original.params.model_copy(
update={
"location": _standardize_deck_slot_location(
original.params.location, robot_type
)
}
)
return original.copy(update={"params": params})
return original.model_copy(update={"params": params})


def _standardize_move_labware(
original: commands.MoveLabwareCreate, robot_type: RobotType
) -> commands.MoveLabwareCreate:
params = original.params.copy(
params = original.params.model_copy(
update={
"newLocation": _standardize_labware_location(
original.params.newLocation, robot_type
)
}
)
return original.copy(update={"params": params})
return original.model_copy(update={"params": params})


_standardize_command_functions: Dict[
Expand Down Expand Up @@ -135,6 +135,6 @@ def _standardize_labware_location(
def _standardize_deck_slot_location(
original: DeckSlotLocation, robot_type: RobotType
) -> DeckSlotLocation:
return original.copy(
return original.model_copy(
update={"slotName": original.slotName.to_equivalent_for_robot_type(robot_type)}
)
6 changes: 3 additions & 3 deletions api/src/opentrons/protocol_engine/state/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,15 +226,15 @@ def handle_action(self, action: Action) -> None: # noqa: C901
# request > command mapping, figure out how to type precisely
# (or wait for a future mypy version that can figure it out).
# For now, unit tests cover mapping every request type
queued_command = action.request._CommandCls.construct(
queued_command = action.request._CommandCls(
id=action.command_id,
key=(
action.request.key
if action.request.key is not None
else (action.request_hash or action.command_id)
),
createdAt=action.created_at,
params=action.request.params,
params=action.request.params, # type: ignore[arg-type]
intent=action.request.intent,
status=CommandStatus.QUEUED,
)
Expand Down Expand Up @@ -527,7 +527,7 @@ def get_error(self) -> Optional[ErrorOccurrence]:
finish_error = self._state.finish_error

if run_error and finish_error:
combined_error = ErrorOccurrence.construct(
combined_error = ErrorOccurrence(
id=finish_error.id,
createdAt=finish_error.createdAt,
errorType="RunAndFinishFailed",
Expand Down
6 changes: 3 additions & 3 deletions api/src/opentrons/protocol_engine/state/labware.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def __init__(
for fixed_labware in deck_fixed_labware
}
labware_by_id = {
fixed_labware.labware_id: LoadedLabware.construct(
fixed_labware.labware_id: LoadedLabware.model_construct(
id=fixed_labware.labware_id,
location=fixed_labware.location,
loadName=fixed_labware.definition.parameters.loadName,
Expand All @@ -156,7 +156,7 @@ def handle_action(self, action: Action) -> None:
self._handle_command(action.command)

elif isinstance(action, AddLabwareOffsetAction):
labware_offset = LabwareOffset.construct(
labware_offset = LabwareOffset.model_construct(
id=action.labware_offset_id,
createdAt=action.created_at,
definitionUri=action.request.definitionUri,
Expand Down Expand Up @@ -190,7 +190,7 @@ def _handle_command(self, command: Command) -> None:

self._state.labware_by_id[
command.result.labwareId
] = LoadedLabware.construct(
] = LoadedLabware.model_construct(
id=command.result.labwareId,
location=command.params.location,
loadName=command.result.definition.parameters.loadName,
Expand Down
2 changes: 1 addition & 1 deletion api/src/opentrons/protocol_engine/state/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def get(self, module_id: str) -> LoadedModule:
DeckSlotLocation(slotName=slot_name) if slot_name is not None else None
)

return LoadedModule.construct(
return LoadedModule.model_construct(
id=module_id,
location=location,
model=attached_module.definition.model,
Expand Down
2 changes: 1 addition & 1 deletion api/src/opentrons/protocol_engine/state/state.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def get_summary(self) -> StateSummary:
"""Get protocol run data."""
error = self._commands.get_error()
# TODO maybe add summary here for AA
return StateSummary.construct(
return StateSummary.model_construct(
status=self._commands.get_status(),
errors=[] if error is None else [error],
pipettes=self._pipettes.get_all(),
Expand Down
3 changes: 1 addition & 2 deletions api/src/opentrons/protocol_runner/json_translator.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ class CommandTranslatorError(Exception):
# serializer. To improve performance, TypeAdapters are instantiated once.
# See https://docs.pydantic.dev/latest/concepts/performance/#typeadapter-instantiated-once
LabwareLocationAdapter: TypeAdapter[LabwareLocation] = TypeAdapter(LabwareLocation) # type: ignore[arg-type]
CommandCreateAdatper: TypeAdapter[pe_commands.CommandCreate] = TypeAdapter(pe_commands.CommandCreate) # type: ignore[arg-type]


def _translate_labware_command(
Expand Down Expand Up @@ -195,7 +194,7 @@ def _translate_simple_command(
else:
dict_command["commandType"] = "waitForDuration"

return CommandCreateAdatper.validate_python(dict_command)
return pe_commands.CommandCreateAdatper.validate_python(dict_command)


class JsonTranslator:
Expand Down

0 comments on commit e83d1b5

Please sign in to comment.