Update todo comments from answers on PR.

Opentrons · Oct 18, 2024 · ce9d55e · ce9d55e
1 parent 5c72fe0
commit ce9d55e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/api/src/opentrons/hardware_control/protocols/__init__.py b/api/src/opentrons/hardware_control/protocols/__init__.py
@@ -60,8 +60,6 @@ def get_robot_type(self) -> Type[OT2RobotType]:
 
     # todo(mm, 2024-10-17): This probably belongs in InstrumentConfigurer, alongside
     # add_tip() and remove_tip().
-    # todo(mm, 2024-10-17): What is the difference between this and add_tip()?
-    # Can one of them be removed?
     def cache_tip(self, mount: MountArgType, tip_length: float) -> None:
         ...
 
@@ -93,8 +91,6 @@ def get_robot_type(self) -> Type[FlexRobotType]:
 
     # todo(mm, 2024-10-17): This probably belongs in InstrumentConfigurer, alongside
     # add_tip() and remove_tip().
-    # todo(mm, 2024-10-17): What is the difference between this and add_tip()?
-    # Can one of them be removed?
     def cache_tip(self, mount: MountArgType, tip_length: float) -> None:
         ...
 

diff --git a/api/src/opentrons/hardware_control/protocols/instrument_configurer.py b/api/src/opentrons/hardware_control/protocols/instrument_configurer.py
@@ -143,8 +143,8 @@ def get_instrument_max_height(
         ...
 
     # todo(mm, 2024-10-17): Can this be made non-async?
-    # todo(mm, 2024-10-17): What is the difference between this and cache_tip()?
-    # Can one of them be removed?
+    # todo(mm, 2024-10-17): Consider deleting this in favor of cache_tip(), which is
+    # the same except for `assert`s, if we can do so without breaking anything.
     async def add_tip(self, mount: MountArgType, tip_length: float) -> None:
         """Inform the hardware that a tip is now attached to a pipette.