Skip to content

Commit

Permalink
remove vitest call to collectCoverageFrom because it does not exist
Browse files Browse the repository at this point in the history
  • Loading branch information
shlokamin committed Mar 4, 2024
1 parent 86b3e96 commit c2eeda5
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/app-test-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
npm config set cache ${{ github.workspace }}/.npm-cache
make setup-js
- name: 'test native(er) packages'
run: make test-js-internal tests="app-shell/src app-shell-odd/src discovery-client/src" cov_opts="--coverage=true --collectCoverageFrom='(app-shell|app-shell-odd| discovery-client)/src/**/*.(js|ts|tsx)'"
run: make test-js-internal tests="app-shell/src app-shell-odd/src discovery-client/src" cov_opts="--coverage=true"
- name: 'Upload coverage report'
uses: 'codecov/codecov-action@v3'
with:
Expand Down
2 changes: 1 addition & 1 deletion app-shell/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ publish_dir := dist/publish
# make test tests=src/__tests__/http.test.ts would run only the
# specified test
tests ?= $(SRC_PATH)/src
cov_opts ?= --coverage=true --collectCoverageFrom='app-shell/src/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# Other SSH args for robot
Expand Down
2 changes: 1 addition & 1 deletion app/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ discovery_client_dir := ../discovery-client
# make test tests=src/pages/Labware/__tests__/hooks.test.tsx would run only the
# specified test
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='app/src/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# standard targets
Expand Down
2 changes: 1 addition & 1 deletion components/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ port ?= 6060
# These variables can be overriden when make is invoked to customize the
# behavior of jest
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='components/src/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# standard targets
Expand Down
3 changes: 1 addition & 2 deletions labware-library/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ PATH := $(shell cd .. && yarn bin):$(PATH)
# These variables can be overriden when make is invoked to customize the
# behavior of jest
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='labware-library/src/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# --coverage=true --collectCoverageFrom="labware-library/src/**/*.(js|ts|tsx)" labware-library/src

.PHONY: all
all: clean dist
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ benchmark_output := $(shell node -e 'console.log(new Date());')
# These variables can be overriden when make is invoked to customize the
# behavior of jest
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='protocol-designer/src/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# standard targets
Expand Down
2 changes: 1 addition & 1 deletion react-api-client/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SHELL := bash
# These variables can be overriden when make is invoked to customize the
# behavior of jest
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='react-api-client/src/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# standard targets
Expand Down
2 changes: 1 addition & 1 deletion shared-data/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SHELL := bash
# These variables can be overriden when make is invoked to customize the
# behavior of jest
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='shared-data/js/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

# Top level targets
Expand Down
2 changes: 1 addition & 1 deletion step-generation/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SHELL := bash
# These variables can be overriden when make is invoked to customize the
# behavior of jest
tests ?=
cov_opts ?= --coverage=true --collectCoverageFrom='step-generation/js/**/*.(js|ts|tsx)'
cov_opts ?= --coverage=true
test_opts ?=

.PHONY: test
Expand Down

0 comments on commit c2eeda5

Please sign in to comment.