Skip to content

Commit

Permalink
fix(app-shell, app-shell-odd): Fix devtools not working on built vers…
Browse files Browse the repository at this point in the history
…ions of desktop app/ODD (#16709)

Works toward EXEC-392
  • Loading branch information
mjhuff authored Nov 7, 2024
1 parent 8784b75 commit b1b4b30
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion app-shell-odd/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ function installDevtools(): void {

log.debug('Installing devtools')

install(extensions, forceReinstall)
install(extensions, {
loadExtensionOptions: { allowFileAccess: true },
forceDownload: forceReinstall,
})
.then(() => log.debug('Devtools extensions installed'))
.catch((error: unknown) => {
log.warn('Failed to install devtools extensions', {
Expand Down
5 changes: 4 additions & 1 deletion app-shell/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,10 @@ function installDevtools(): Promise<Logger> {
log.debug('Installing devtools')

if (typeof install === 'function') {
return install(extensions, forceReinstall)
return install(extensions, {
loadExtensionOptions: { allowFileAccess: true },
forceDownload: forceReinstall,
})
.then(() => log.debug('Devtools extensions installed'))
.catch((error: unknown) => {
log.warn('Failed to install devtools extensions', {
Expand Down

0 comments on commit b1b4b30

Please sign in to comment.