put behind ff

Opentrons · Mar 14, 2024 · 97cec55 · 97cec55
1 parent ffcce62
commit 97cec55
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/app/src/pages/ProtocolDetails/__tests__/ProtocolDetails.test.tsx b/app/src/pages/ProtocolDetails/__tests__/ProtocolDetails.test.tsx
@@ -21,6 +21,7 @@ import { i18n } from '../../../i18n'
 import { useHardwareStatusText } from '../../../organisms/OnDeviceDisplay/RobotDashboard/hooks'
 import { useOffsetCandidatesForAnalysis } from '../../../organisms/ApplyHistoricOffsets/hooks/useOffsetCandidatesForAnalysis'
 import { useMissingProtocolHardware } from '../../Protocols/hooks'
+import { useFeatureFlag } from '../../../redux/config'
 import { formatTimeWithUtcLabel } from '../../../resources/runs'
 import { ProtocolDetails } from '..'
 import { Deck } from '../Deck'
@@ -52,6 +53,7 @@ vi.mock('../Deck')
 vi.mock('../Hardware')
 vi.mock('../Labware')
 vi.mock('../Parameters')
+vi.mock('../../../redux/config')
 
 const MOCK_HOST_CONFIG = {} as HostConfig
 const mockCreateRun = vi.fn((id: string) => {})
@@ -90,6 +92,7 @@ const render = (path = '/protocols/fakeProtocolId') => {
 
 describe('ODDProtocolDetails', () => {
   beforeEach(() => {
+    vi.mocked(useFeatureFlag).mockReturnValue(true)
     vi.mocked(useCreateRunMutation).mockReturnValue({
       createRun: mockCreateRun,
     } as any)

diff --git a/app/src/pages/ProtocolDetails/index.tsx b/app/src/pages/ProtocolDetails/index.tsx
@@ -44,6 +44,7 @@ import {
   getApplyHistoricOffsets,
   getPinnedProtocolIds,
   updateConfigValue,
+  useFeatureFlag,
 } from '../../redux/config'
 import { useOffsetCandidatesForAnalysis } from '../../organisms/ApplyHistoricOffsets/hooks/useOffsetCandidatesForAnalysis'
 import { useMissingProtocolHardware } from '../Protocols/hooks'
@@ -163,8 +164,17 @@ const protocolSectionTabOptions = [
   'Liquids',
   'Deck',
 ] as const
+const protocolSectionTabOptionsWithoutParameters = [
+  'Summary',
+  'Hardware',
+  'Labware',
+  'Liquids',
+  'Deck',
+] as const
 
-type TabOption = typeof protocolSectionTabOptions[number]
+type TabOption =
+  | typeof protocolSectionTabOptions[number]
+  | typeof protocolSectionTabOptionsWithoutParameters[number]
 
 interface ProtocolSectionTabsProps {
   currentOption: TabOption
@@ -175,9 +185,13 @@ const ProtocolSectionTabs = ({
   currentOption,
   setCurrentOption,
 }: ProtocolSectionTabsProps): JSX.Element => {
+  const enableRtpFF = useFeatureFlag('enableRunTimeParameters')
+  const options = enableRtpFF
+    ? protocolSectionTabOptions
+    : protocolSectionTabOptionsWithoutParameters
   return (
     <Flex gridGap={SPACING.spacing8}>
-      {protocolSectionTabOptions.map(option => {
+      {options.map(option => {
         return (
           <TabbedButton
             isSelected={option === currentOption}
@@ -290,6 +304,7 @@ export function ProtocolDetails(): JSX.Element | null {
     'protocol_info',
     'shared',
   ])
+  const enableRtpFF = useFeatureFlag('enableRunTimeParameters')
   const { protocolId } = useParams<OnDeviceRouteParams>()
   const {
     missingProtocolHardware,
@@ -305,8 +320,11 @@ export function ProtocolDetails(): JSX.Element | null {
   const { makeSnackbar } = useToaster()
   const queryClient = useQueryClient()
   const [currentOption, setCurrentOption] = React.useState<TabOption>(
-    protocolSectionTabOptions[0]
+    enableRtpFF
+      ? protocolSectionTabOptions[0]
+      : protocolSectionTabOptionsWithoutParameters[0]
   )
+
   const [showMaxPinsAlert, setShowMaxPinsAlert] = React.useState<boolean>(false)
   const {
     data: protocolRecord,