-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(api): Enable more type-checking inside pipette_handler.py (#…
…16523) ## Overview Delete some `@overload`s that didn't seem like they were doing anything, and reincorporate their parameter annotations into the main function definitions. Formerly, the main function bodies were mostly not type-checked because the parameters didn't have annotations. (It's perhaps surprising that they didn't automatically "inherit" the annotations from the `@overload`s, but I guess mypy and pyright just don't work like that.) This fixes that. ## Test Plan and Hands on Testing None needed, just automated linting and tests. ## Review requests Any reason not to do this? ## Risk assessment Low.
- Loading branch information
1 parent
24fcc0d
commit 965bc0d
Showing
1 changed file
with
11 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters