Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ncdiehl11 committed May 2, 2024
1 parent f3a5d2e commit 92476d3
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions app/src/organisms/RunPreview/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,8 @@ export const RunPreviewComponent = (
? nullCheckedCommandsFromQuery
: robotSideAnalysis.commands) ?? []
// pass relevant data from run rather than analysis so that CommandText utilities can properly hash the entities' IDs
// TODO (nd:05/02/2024): update name and types for CommandText (and children/utilities) use of analysis. These children
// and utilities need only a subset of data provided by analysis, and there should be an overlap of these required data
// between a completed analysis and a run record, so we shouldn't pass down a franken-analysis, but rather a new interface
// with just the required data coming from the analysis OR the run.
// TODO (nd:05/02/2024, AUTH-380): update name and types for CommandText (and children/utilities) use of analysis.
// We should ideally pass only subset of analysis/run data required by these children and utilities
const protocolDataFromAnalysisOrRun =
isRunTerminal && runRecord?.data != null
? {
Expand Down

0 comments on commit 92476d3

Please sign in to comment.