Skip to content

Commit

Permalink
notes from discussion with Seth
Browse files Browse the repository at this point in the history
  • Loading branch information
pmoegenburg committed Feb 22, 2024
1 parent be27946 commit 923a5e6
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ async def _run_one_group(self, group_id: int, can_messenger: CanMessenger) -> No

log.debug(f"Executing move group {group_id}.")
self._current_group = group_id - self._start_at_index
error = await can_messenger.ensure_send(
error = await can_messenger.ensure_send( # catches Error response as opposed to ack response??
node_id=NodeId.broadcast,
message=ExecuteMoveGroupRequest(
payload=ExecuteMoveGroupRequestPayload(
Expand All @@ -587,6 +587,8 @@ async def _run_one_group(self, group_id: int, can_messenger: CanMessenger) -> No
if error != ErrorCode.ok:
log.error(f"received error trying to execute move group: {str(error)}")

# just report errors when move requested
# we want to report follow-up message! Just let logs gather it if error doesn't occur during a move? Do we collect non-response (error) messages??
expected_time = max(3.0, self._durations[group_id - self._start_at_index] * 1.1)
full_timeout = max(5.0, self._durations[group_id - self._start_at_index] * 2)
start_time = time.time()
Expand Down

0 comments on commit 923a5e6

Please sign in to comment.