Skip to content

Commit

Permalink
refactor(modules): return has update for unexpected module fw filename (
Browse files Browse the repository at this point in the history
  • Loading branch information
caila-marashaj authored and Carlos-fernandez committed May 20, 2024
1 parent 27231c5 commit 7ec950c
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions api/src/opentrons/hardware_control/modules/mod_abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import re
from pkg_resources import parse_version
from typing import ClassVar, Mapping, Optional, cast, TypeVar

from packaging.version import InvalidVersion
from opentrons.config import IS_ROBOT, ROBOT_FIRMWARE_DIR
from opentrons.drivers.rpi_drivers.types import USBPort

Expand Down Expand Up @@ -88,8 +88,15 @@ def get_bundled_fw(self) -> Optional[BundledFirmware]:
def has_available_update(self) -> bool:
"""Return whether a newer firmware file is available"""
if self.device_info and self._bundled_fw:
device_version = parse_version(self.device_info["version"])
available_version = parse_version(self._bundled_fw.version)
# try catch this
try:
device_version = parse_version(self.device_info["version"])
except InvalidVersion:
device_version = parse_version("v0.0.0")
try:
available_version = parse_version(self._bundled_fw.version)
except InvalidVersion:
available_version = parse_version("v0.0.0")
return cast(bool, available_version > device_version)
return False

Expand Down

0 comments on commit 7ec950c

Please sign in to comment.