Skip to content

Commit

Permalink
fix(app): fix release notes url in ODD settings (#13456)
Browse files Browse the repository at this point in the history
Provide full path to opentrons github releases in URL of ODD robot version settings page.

Closes RAUT-658
  • Loading branch information
b-cooper authored Sep 1, 2023
1 parent cbccf7d commit 76fd7e7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/src/assets/localization/en/device_settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
"use_older_protocol_analysis_method": "Use older protocol analysis method",
"validating_software": "Validating software...",
"view_details": "View details",
"view_latest_release_notes_at": "View latest release notes at ",
"view_latest_release_notes_at": "View latest release notes at {{url}}",
"view_network_details": "View network details",
"view_opentrons_issue_tracker": "View Opentrons issue tracker",
"view_opentrons_release_notes": "View full Opentrons release notes",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { getShellUpdateState } from '../../redux/shell'

import type { SetSettingOption } from '../../pages/OnDeviceDisplay/RobotSettingsDashboard'

const GITHUB_URL = 'https://github.com/Opentrons/opentrons'
const GITHUB_URL = 'https://github.com/Opentrons/opentrons/releases'

interface RobotSystemVersionProps {
currentVersion: string
Expand Down Expand Up @@ -77,9 +77,9 @@ export function RobotSystemVersion({
marginTop="7.75rem"
>
<Flex flexDirection={DIRECTION_COLUMN} gridGap={SPACING.spacing24}>
<StyledText as="p">{`${t(
'view_latest_release_notes_at'
)} ${GITHUB_URL}`}</StyledText>
<StyledText as="p">
{t('view_latest_release_notes_at', { url: GITHUB_URL })}
</StyledText>
<Flex
backgroundColor={COLORS.light1}
flexDirection={DIRECTION_ROW}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('RobotSystemVersion', () => {
const [{ getByText }] = render(props)
getByText('Robot System Version')
getByText(
'View latest release notes at https://github.com/Opentrons/opentrons'
'View latest release notes at https://github.com/Opentrons/opentrons/releases'
)
getByText('Current Version:')
getByText('mock7.0.0')
Expand Down

0 comments on commit 76fd7e7

Please sign in to comment.