Skip to content

Commit

Permalink
fix(api): Do not pass loop arg to subproc (#14570)
Browse files Browse the repository at this point in the history
asyncio subprocess used to need loop; now it doesn't. For a
minimum-affected fix, just don't pass loop to the subprocess invocations
while keeping it in the top level environment.

Closes RQA-2417
  • Loading branch information
sfoster1 authored Feb 29, 2024
1 parent 41c7af5 commit 6c5a6dc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion api/src/opentrons/hardware_control/modules/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ async def update_firmware(
kwargs: Dict[str, Any] = {
"stdout": asyncio.subprocess.PIPE,
"stderr": asyncio.subprocess.PIPE,
"loop": loop,
}
successful, res = await module.bootloader()(
flash_port_or_dfu_serial, str(firmware_file), kwargs
Expand Down
1 change: 0 additions & 1 deletion api/tests/opentrons/hardware_control/test_modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ def async_return(result):
bootloader_kwargs = {
"stdout": asyncio.subprocess.PIPE,
"stderr": asyncio.subprocess.PIPE,
"loop": loop,
}

upload_via_avrdude_mock = mock.Mock(
Expand Down

0 comments on commit 6c5a6dc

Please sign in to comment.