Skip to content

Commit

Permalink
fix up PD production build
Browse files Browse the repository at this point in the history
  • Loading branch information
shlokamin committed Feb 22, 2024
1 parent f33c484 commit 688650c
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/pd-test-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ jobs:
run: make -C protocol-designer test-e2e
build-pd:
name: 'build protocol designer artifact'
needs: ['js-unit-test']
# TODO: uncomment code below. doing this to test that PD artifacts build and deploy correctly
# needs: ['js-unit-test']
runs-on: 'ubuntu-22.04'
if: github.event_name != 'pull_request'
steps:
Expand Down Expand Up @@ -136,7 +137,8 @@ jobs:
deploy-pd:
name: 'deploy PD artifact to S3'
runs-on: 'ubuntu-22.04'
needs: ['js-unit-test', 'build-pd']
# TODO: uncomment code below. doing this to test that PD artifacts build and deploy correctly
needs: ['build-pd']
if: github.event_name != 'pull_request'
steps:
- uses: 'actions/checkout@v3'
Expand Down
16 changes: 16 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions protocol-designer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"@opentrons/step-generation": "link:../step-generation",
"@opentrons/shared-data": "link:../shared-data",
"@types/redux-actions": "2.6.1",
"@types/styled-components": "^5.1.26",
"@types/ua-parser-js": "0.7.36",
"@types/uuid": "8.3.0",
"@typescript-eslint/eslint-plugin": "^6.10.0",
Expand All @@ -41,6 +42,7 @@
"i18next": "^19.8.3",
"immer": "9.0.6",
"lodash": "4.17.21",
"mixpanel-browser": "2.22.1",
"query-string": "6.2.0",
"react": "18.2.0",
"react-color": "2.19.3",
Expand All @@ -52,8 +54,10 @@
"react-redux": "8.1.2",
"redux": "4.0.5",
"redux-actions": "2.2.1",
"react-popper": "1.0.0",
"redux-thunk": "2.3.0",
"reselect": "4.0.0",
"styled-components": "5.3.6",
"ua-parser-js": "^0.7.23",
"uuid": "3.3.2",
"vite": "5.0.5",
Expand All @@ -67,5 +71,8 @@
"postcss-preset-env": "9.3.0",
"postcss-color-mod-function": "3.0.3",
"yup": "1.3.3"
},
"devDependencies": {
"@types/mixpanel-browser": "^2.35.6"
}
}

0 comments on commit 688650c

Please sign in to comment.