Skip to content

Commit

Permalink
works using execute
Browse files Browse the repository at this point in the history
  • Loading branch information
andySigler committed Mar 11, 2024
1 parent 11babab commit 637698b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion api/src/opentrons/motion_planning/waypoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_gripper_labware_movement_waypoints(
waypoints_with_jaw_status = [
GripperMovementWaypointsWithJawStatus(
position=Point(pick_up_location.x, pick_up_location.y, gripper_home_z),
jaw_open=False,
jaw_open=True,
dropping=False,
),
GripperMovementWaypointsWithJawStatus(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ async def move_labware_with_gripper(
)
labware_grip_force = self._state_store.labware.get_grip_force(labware_id)
holding_labware = False
await ot3api.ungrip()
for waypoint_data in movement_waypoints:
if waypoint_data.jaw_open:
if waypoint_data.dropping:
Expand Down Expand Up @@ -191,7 +192,8 @@ async def move_labware_with_gripper(
)

# this makes sure gripper jaw is closed between two move labware calls
await ot3api.idle_gripper()
# await ot3api.idle_gripper()
await ot3api.ungrip()

async def ensure_movement_not_obstructed_by_module(
self, labware_id: str, new_location: LabwareLocation
Expand Down
6 changes: 3 additions & 3 deletions api/src/opentrons/protocol_engine/state/geometry.py
Original file line number Diff line number Diff line change
Expand Up @@ -1071,12 +1071,12 @@ def _labware_gripper_offsets(
"""
parent_location = self._labware.get_location(labware_id)
assert isinstance(
parent_location, (DeckSlotLocation, ModuleLocation, OnLabwareLocation)
), "No gripper offsets for off-deck labware"
parent_location, (DeckSlotLocation, ModuleLocation, AddressableAreaLocation)
), f"No gripper offsets for off-deck labware: {type(parent_location)}"

if isinstance(parent_location, DeckSlotLocation):
slot_name = parent_location.slotName
elif isinstance(parent_location, OnLabwareLocation):
elif isinstance(parent_location, AddressableAreaLocation):
slot_name = self._labware.get_parent_location(labware_id).slotName
else:
module_loc = self._modules.get_location(parent_location.moduleId)
Expand Down

0 comments on commit 637698b

Please sign in to comment.