removed comments

Opentrons · Oct 23, 2024 · 5bafa09 · 5bafa09
1 parent 2332aac
commit 5bafa09
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/api/src/opentrons/protocol_engine/state/geometry.py b/api/src/opentrons/protocol_engine/state/geometry.py
@@ -1488,10 +1488,10 @@ def validate_dispense_volume_into_well(
         volume: float,
     ) -> None:
         """Raise InvalidDispenseVolumeError if planned dispense volume will overflow well."""
-        # update this (or where it's used)? Consider how many conversions are being done
         well_def = self._labware.get_well_definition(labware_id, well_name)
         well_volumetric_capacity = well_def.totalLiquidVolume
         if well_location.origin == WellOrigin.MENISCUS:
+            # TODO(pbm, 10-23-24): refactor to smartly reduce height/volume conversions
             well_geometry = self._labware.get_well_geometry(labware_id, well_name)
             meniscus_height = self.get_meniscus_height(
                 labware_id=labware_id, well_name=well_name

diff --git a/api/src/opentrons/protocol_engine/state/wells.py b/api/src/opentrons/protocol_engine/state/wells.py
@@ -128,10 +128,6 @@ def __init__(self, state: WellState) -> None:
         """
         self._state = state
 
-    # if volume requested, loaded_volumes or probed_volumes
-    # if height requested, probed_heights or loaded_vols_to_height or probed_vols_to_height
-    # to get height, call GeometryView.get_well_height, which does conversion if needed
-
     def get_all(
         self,
     ) -> List[Union[ProbedHeightSummary, ProbedVolumeSummary, LoadedVolumeSummary]]: