Code review cleanup comments

Opentrons · Mar 26, 2024 · 5292830 · 5292830
1 parent 829804d
commit 5292830
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/app/src/organisms/Devices/PipetteCard/FlexPipetteCard.tsx b/app/src/organisms/Devices/PipetteCard/FlexPipetteCard.tsx
@@ -21,12 +21,7 @@ import { DropTipWizard } from '../../DropTipWizard'
 
 import { AboutPipetteSlideout } from './AboutPipetteSlideout'
 
-import type {
-  BadPipette,
-  Mount,
-  PipetteData,
-  HostConfig,
-} from '@opentrons/api-client'
+import type { BadPipette, Mount, PipetteData } from '@opentrons/api-client'
 import type { PipetteModelSpecs } from '@opentrons/shared-data'
 import type {
   PipetteWizardFlow,
@@ -66,7 +61,7 @@ export function FlexPipetteCard({
   isEstopNotDisengaged,
 }: FlexPipetteCardProps): JSX.Element {
   const { t, i18n } = useTranslation(['device_details', 'shared'])
-  const host = useHost() as HostConfig
+  const host = useHost()
 
   const [
     showAboutPipetteSlideout,
@@ -258,15 +253,15 @@ export function FlexPipetteCard({
           closeFlow={() => setShowDropTipWizard(false)}
         />
       ) : null}
-      {attachedPipette?.ok && showAboutPipetteSlideout && (
+      {attachedPipette?.ok && showAboutPipetteSlideout ? (
         <AboutPipetteSlideout
           pipetteId={attachedPipette.serialNumber}
           pipetteName={pipetteDisplayName ?? attachedPipette.instrumentName}
           firmwareVersion={attachedPipette.firmwareVersion}
           isExpanded={showAboutPipetteSlideout}
           onCloseClick={() => setShowAboutPipetteSlideout(false)}
         />
-      )}
+      ) : null}
       {showChoosePipette ? (
         <ChoosePipette
           proceed={handleAttach}

diff --git a/app/src/organisms/Devices/PipetteCard/__tests__/FlexPipetteCard.test.tsx b/app/src/organisms/Devices/PipetteCard/__tests__/FlexPipetteCard.test.tsx
@@ -4,14 +4,14 @@ import { describe, it, vi, beforeEach, afterEach, expect } from 'vitest'
 import { renderWithProviders } from '../../../../__testing-utils__'
 import { useCurrentSubsystemUpdateQuery } from '@opentrons/react-api-client'
 import { i18n } from '../../../../i18n'
+import { mockLeftSpecs } from '../../../../redux/pipettes/__fixtures__'
 import { handlePipetteWizardFlows } from '../../../PipetteWizardFlows'
 import { AboutPipetteSlideout } from '../AboutPipetteSlideout'
 import { FlexPipetteCard } from '../FlexPipetteCard'
 import { ChoosePipette } from '../../../PipetteWizardFlows/ChoosePipette'
 import { DropTipWizard } from '../../../DropTipWizard'
 
 import type { PipetteData } from '@opentrons/api-client'
-import { mockLeftSpecs } from '../../../../redux/pipettes/__fixtures__'
 
 vi.mock('../../../PipetteWizardFlows')
 vi.mock('../../../PipetteWizardFlows/ChoosePipette')

diff --git a/app/src/organisms/Devices/PipetteCard/index.tsx b/app/src/organisms/Devices/PipetteCard/index.tsx
@@ -142,7 +142,7 @@ export const PipetteCard = (props: PipetteCardProps): JSX.Element => {
                   pipetteSpecs={pipetteModelSpecs}
                   mount={mount}
                   transform="scale(0.3)"
-                  transformOrigin={'20% 52%'}
+                  transformOrigin="20% 52%"
                 />
               </Flex>
             ) : null}