Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(opentrons-shared-data): fix performance module not being recogniz…
…ed (#14990) # Overview Fixes https://opentrons.atlassian.net/browse/RQA-2623 performance directory was missing an `__init__.py` # Test Plan - I added a test just to import the module and create one of the objects inside the dev_types.py. The issue is that the tests don't run against the built version of the package. I built the app and everything imports correctly - I cannot test that opentrons_shared_data is being utilized correctly on the robot until I have a built buildroot image. Because currently my robot and app have different versions (due to the dev build) so the app will not let me trigger an analysis. - I instead pushed opentrons-shared-data to my robot and verified that the performance module existed in `/usr/lib/python3.10/site-packages/opentrons_shared_data`. But I can't test that the imports actually work until I have the system image and the app together # Changelog - Added `__init__.py` to performance directory to tell python to import it as a module - Reorganized performance_helpers.py to not have an import error # Review requests - Nothing to block this fix, but what should be done to make sure this doesn't happen again? This is a weird packaging thing that doesn't show up when running dev or CI testing. - I wonder if there is a smoke test we can perform automatically just to make sure everything imports correctly? Running opentrons.simulate against the actual built package would have caught this # Risk assessment Medium, I mean I can't break it any worse than I already did
- Loading branch information