Skip to content

Commit

Permalink
fix(app): fix protocol summary text wrapping issue on ODD (#16281)
Browse files Browse the repository at this point in the history
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
fix protocol summary text wrapping issue on ODD

### before
![Screenshot 2024-09-17 at 5 54
37 PM](https://github.com/user-attachments/assets/2b9eaae0-259c-47e8-a0e4-281ee2f58b70)

### after
![Screenshot 2024-09-17 at 5 56
32 PM](https://github.com/user-attachments/assets/0855639d-01be-429a-9532-fc9fc0655c3f)


<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog
- add text overlapping style to ODD
<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment
low
<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
  • Loading branch information
koji authored Sep 18, 2024
1 parent 7ff4b9f commit 3a8bfc8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/src/pages/ProtocolDetails/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ const Summary = ({ author, description, date }: SummaryProps): JSX.Element => {
<LegacyStyledText
as="p"
color={description === null ? COLORS.grey60 : undefined}
overflowWrap={OVERFLOW_WRAP_ANYWHERE}
>
{description ?? i18n.format(t('no_summary'), 'capitalize')}
</LegacyStyledText>
Expand Down

0 comments on commit 3a8bfc8

Please sign in to comment.