bad snap and better diff capture

Opentrons · Jul 25, 2024 · 32a2737 · 32a2737
1 parent a3dfe42
commit 32a2737
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/.github/workflows/analyses-snapshot-test.yaml b/.github/workflows/analyses-snapshot-test.yaml
@@ -61,7 +61,7 @@ jobs:
         run: |
           git fetch origin ${{ env.PR_TARGET_BRANCH }}
           DIFF_OUTPUT=$(git diff HEAD origin/${{ env.PR_TARGET_BRANCH }} -- analyses-snapshot-testing/tests/__snapshots__/analyses_snapshot_test)
-          if [ $DIFF_EXIT_CODE -eq 0 ]; then
+          if [ -n "$DIFF_OUTPUT" ]; then
             echo "Analyses snapshots match ${{ env.PR_TARGET_BRANCH }} snapshots."
           else
             echo "Analyses snapshots do NOT match ${{ env.PR_TARGET_BRANCH }} snapshots."

diff --git a/...snapshot_test/test_analysis_snapshot[0a9ef592c8][Flex_S_v2_18_Illumina_DNA_Prep_48x].json b/...snapshot_test/test_analysis_snapshot[0a9ef592c8][Flex_S_v2_18_Illumina_DNA_Prep_48x].json
@@ -1,17 +1,5 @@
 {
   "commands": [
-    {
-      "commandType": "home",
-      "completedAt": "TIMESTAMP",
-      "createdAt": "TIMESTAMP",
-      "id": "UUID",
-      "key": "50c7ae73a4e3f7129874f39dfb514803",
-      "notes": [],
-      "params": {},
-      "result": {},
-      "startedAt": "TIMESTAMP",
-      "status": "succeeded"
-    },
     {
       "commandType": "loadPipette",
       "completedAt": "TIMESTAMP",