Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jerader committed May 9, 2024
1 parent 23abf54 commit 06d0c33
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,29 +74,23 @@ export function TiprackOption(props: TiprackOptionProps): JSX.Element {
<>
<Flex
aria-label={`TiprackOption_flex_${text}`}
cursor="pointer"
onClick={isDisabled ? undefined : onClick}
flexDirection={DIRECTION_ROW}
alignItems={ALIGN_CENTER}
width="13.5rem"
css={optionStyle}
padding={SPACING.spacing8}
border={
isSelected && !isDisabled
? BORDERS.activeLineBorder
: BORDERS.lineBorder
}
borderRadius={BORDERS.borderRadius8}
cursor={isDisabled ? 'auto' : 'pointer'}
backgroundColor={COLORS.transparent}
{...targetProps}
>
<StyledText
as="label"
width="13.5rem"
css={optionStyle}
alignItems={ALIGN_CENTER}
padding={SPACING.spacing8}
border={
isSelected && !isDisabled
? BORDERS.activeLineBorder
: BORDERS.lineBorder
}
borderRadius={BORDERS.borderRadius8}
cursor={isDisabled ? 'auto' : 'pointer'}
backgroundColor={COLORS.transparent}
>
{text}
</StyledText>
<StyledText as="label">{text}</StyledText>
</Flex>
{isDisabled ? (
<Tooltip {...tooltipProps}>{t('disabled_no_space_pipette')}</Tooltip>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const TiprackSelect = (
marginBottom={SPACING.spacing4}
width="max-width"
key={`${option.name}_${index}`}
overflow="hidden"
>
<TiprackOption
isDisabled={
Expand Down

0 comments on commit 06d0c33

Please sign in to comment.