-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate koba & migrate e2e tests to alloy #80
Merged
Merged
Changes from all commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
48d7190
feat: add constructor for erc20-example
alexfertel e7e30cf
feat: add constructors for the rest of the examples
alexfertel 5eb4af1
fix: remove remaining references to constructors
alexfertel 823b471
Merge branch 'main' into constructors
alexfertel ba776e8
Merge branch 'main' into constructors
alexfertel 4a9a847
feat: add koba as a git dependency
alexfertel e775135
feat: replace ethers with alloy
alexfertel ffd3016
Merge branch 'migrate-tests-to-alloy' into constructors
alexfertel e0f7e6c
feat: add erc20-example integration tests' setup
alexfertel ed35ae4
fix: wip
alexfertel cc36c5f
wip
alexfertel b92c225
wip
alexfertel 64ff2fc
fix: properly parse private keys
alexfertel f4e4a93
fix: properly set pkg name
alexfertel 217f45c
dbg
alexfertel 1363e41
wip
alexfertel e950399
dbg
alexfertel 0265316
dbg
alexfertel 2aa6814
dbg
alexfertel 6d0a482
dbg
alexfertel 8089f67
dbg
alexfertel f819ffd
dbg
alexfertel b31c682
dbg
alexfertel baaf3e8
dbg
alexfertel 97ce174
dbg
alexfertel 1f6dcba
dbg
alexfertel 7fbc015
dbg
alexfertel 6b9e5cf
dbg
alexfertel 7048386
dbg
alexfertel 6833d96
dbg
alexfertel 3f7e4cf
dbg
alexfertel c28d12f
dbg
alexfertel 29d8016
dbg
alexfertel 1a7237f
dbg
alexfertel 54a7477
dbg
alexfertel c0e558c
dbg
alexfertel be4053e
dbg
alexfertel 8a90a18
dbg
alexfertel 50bbc79
dbg
alexfertel 644a871
dbg
alexfertel f5280fc
dbg
alexfertel b35b215
dbg
alexfertel c10cd20
dbg
alexfertel 380bffe
dbg
alexfertel bf7e79c
dbg
alexfertel 934d355
dbg
alexfertel fd503ec
dbg
alexfertel 5d45c6a
dbg
alexfertel cc55fd6
dbg
alexfertel 298add6
dbg
alexfertel 50cfb2d
dbg
alexfertel 8946d04
dbg
alexfertel 7fe83cb
dbg
alexfertel 9aede70
dbg
alexfertel 7b5dcc8
dbg
alexfertel 76233e9
dbg
alexfertel 7c2e692
dbg
alexfertel c9b48c4
dbg
alexfertel ad8a42a
fix: add proper support for deploying to nitro-testnode
alexfertel 20c2a0b
fix: stop deploying contracts before tests run
alexfertel 5efefde
Merge branch 'main' into constructors
alexfertel 1b40e5f
ref: migrate to using alloy
alexfertel 6ea618c
lint(fmt): fix formatting
alexfertel 365a4b0
fix(e2e): set env variables properly
alexfertel 769fdc0
fix(e2e): clone nitro testnode in workspace root
alexfertel 9cb8b46
fix(e2e): clone nitro testnode in workspace root
alexfertel d13a310
dbg
alexfertel db48dc0
fix(e2e): properly format fund address
alexfertel cb93510
ref: trim down erc721 example so that it's deployable on stable
alexfertel 39239c2
Revert "ref: trim down erc721 example so that it's deployable on stable"
alexfertel 39eb27a
fix: use nightly to fit contract size limit
alexfertel f3a0494
dbg
alexfertel ea26710
fix: activate only once
alexfertel b401e79
Update lib/e2e/src/deploy.rs
qalisander 9747760
fix: actually send txs to the network in tests
alexfertel 7edf5f6
fix: skip running unit tests on e2e ci
alexfertel 98c19a0
Merge branch 'constructors' of https://github.com/OpenZeppelin/rust-c…
alexfertel cf6e716
ref: extract abi from example tests
alexfertel 4eed895
lint(fmt): fix formatting
alexfertel ef8474e
fix: expect receiving the receipt instead of just watching txs
alexfertel 7f9f342
test(erc20): test contract construction onchain
alexfertel 0fe8ae1
fix(e2e): properly implement alloy error assertions
alexfertel 733084e
fix(e2e): properly set from field of txs
alexfertel bb7d586
ref: remove unnecessary comment
alexfertel 5b440f3
fix: use parent path in nitro-testnode script
alexfertel b9d2bfb
chore: link to GH issue for nitro-testnode work
alexfertel 0e4bbdc
ref: dedup RPC_URL name locations
alexfertel 6bdc04a
ref: simplify code a bit
alexfertel 5b6fd4c
chore: link to GH issue
alexfertel b94bfb6
fix: typo in comment
alexfertel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,9 @@ name: e2e-tests | |
| # | ||
| # It roughly follows these steps: | ||
| # - A local `nitro-testnode` gets spun up. | ||
| # - The test suite runs | ||
| # Test contract deployments and test user funding happen per test. | ||
| # - The test suite runs. | ||
| # | ||
| # Contract deployments and account funding happen on a per-test basis. | ||
| permissions: | ||
| contents: read | ||
| on: | ||
|
|
@@ -52,9 +53,13 @@ jobs: | |
| run: RUSTFLAGS="-C link-args=-rdynamic" cargo install [email protected] | ||
|
|
||
| - name: setup nitro node | ||
| run: ./e2e-tests/nitro-testnode.sh -d -i | ||
|
|
||
| run: ./scripts/nitro-testnode.sh -d -i | ||
| - name: install solc | ||
| run: | | ||
| curl -LO https://github.com/ethereum/solidity/releases/download/v0.8.21/solc-static-linux | ||
| sudo mv solc-static-linux /usr/bin/solc | ||
| sudo chmod a+x /usr/bin/solc | ||
| - name: run integration tests | ||
| run: | | ||
| export NIGHTLY_TOOLCHAIN=${{steps.toolchain.outputs.name}} | ||
| ./e2e-tests/test.sh | ||
| ./scripts/e2e-tests.sh | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also are we going to write tests for test framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is fine to have a full test coverage just for contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should, but it's low priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that it is as low priority that we shall not think about it right now. Good proof that testing framework working as expected are basically "green" tests that use it.