Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: turn contracts into a crate #6

Merged
merged 3 commits into from
Mar 25, 2024
Merged

ref: turn contracts into a crate #6

merged 3 commits into from
Mar 25, 2024

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Mar 25, 2024 •
edited
Loading

Contracts directory as a separate crate.
Template for erc721.

@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited
Loading

👷 Deploy request for contracts-stylus pending review.

A Netlify team Owner will need to approve the deploy before you can run your build.

Are you a team Owner? Visit the deploys page to approve it →

Need more help? Learn more in the Netlify docs →

Name Link
🔨 Latest commit 76de402

alexfertel
alexfertel previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@alexfertel alexfertel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Edit: Updated the PR title so that it adheres to our guidelines. Basically the idea is to use conventional commits so that we can keep a changelog easily later when we start making releases. (There are tools to automate changelog generation like https://git-cliff.org/)

contracts/Cargo.toml Show resolved Hide resolved
contracts/src/lib.rs Show resolved Hide resolved
contracts/src/erc20/mod.rs Show resolved Hide resolved
@alexfertel alexfertel changed the title Change project layout ref: turn contracts into a crate Mar 25, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

The author of this PR, qalisander, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@qalisander qalisander merged commit 1c4b23b into main Mar 25, 2024
14 checks passed
@alexfertel alexfertel deleted the change-project-layout branch March 25, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfertel alexfertel alexfertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qalisander @alexfertel