Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): deploy contracts without Solidity constructor when not needed #295

Merged

Conversation

TucksonDev
Copy link
Contributor

@TucksonDev TucksonDev commented Sep 20, 2024

This PR changes the e2e testing library to allow deployments of contracts without a constructor., when the constructor file is not present. This is already allowed by koba.

Resolves #???

PR Checklist

  • Tests
  • Documentation (not required)

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit a9cdbd3
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66f15b4378ae0f0008f8f0d0

@bidzyyys bidzyyys changed the title chore: add possibility of deploying contracts without constructor through e2e fix(e2e): deploy contracts without constructor through e2e Sep 21, 2024
@bidzyyys bidzyyys changed the title fix(e2e): deploy contracts without constructor through e2e fix(e2e): deploy contracts without Solidity constructor when not needed Sep 21, 2024
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me 👍

Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jose! Thanks for the contribution.
I've fixed final formatting issue and I think we are ready to merge

@qalisander qalisander merged commit 8fb2758 into OpenZeppelin:main Sep 23, 2024
21 checks passed
@bidzyyys bidzyyys mentioned this pull request Oct 2, 2024
2 tasks
@0xNeshi 0xNeshi mentioned this pull request Nov 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants