-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): deploy contracts without Solidity constructor when not needed #295
Merged
qalisander
merged 5 commits into
OpenZeppelin:main
from
TucksonDev:add-e2e-deployment-without-constructor
Sep 23, 2024
Merged
fix(e2e): deploy contracts without Solidity constructor when not needed #295
qalisander
merged 5 commits into
OpenZeppelin:main
from
TucksonDev:add-e2e-deployment-without-constructor
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-stylus canceled.
|
bidzyyys
changed the title
chore: add possibility of deploying contracts without constructor through e2e
fix(e2e): deploy contracts without constructor through e2e
Sep 21, 2024
bidzyyys
changed the title
fix(e2e): deploy contracts without constructor through e2e
fix(e2e): deploy contracts without Solidity constructor when not needed
Sep 21, 2024
bidzyyys
reviewed
Sep 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me 👍
qalisander
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jose! Thanks for the contribution.
I've fixed final formatting issue and I think we are ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
e2e
testing library to allow deployments of contracts without a constructor., when the constructor file is not present. This is already allowed by koba.Resolves #???PR Checklist
Documentation(not required)