-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: increase code coverage at consecutive #293
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
} | ||
|
||
#[motsu::test] | ||
fn error_when_safe_transfer_transfers_from_incorrect_owner( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would skip the naming convention we decided some time ago and leave: error_when_safe_transfers_from_incorrect_owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies to all tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment regarding naming convention.
@@ -2306,7 +2306,7 @@ mod tests { | |||
} | |||
|
|||
#[motsu::test] | |||
fn error_when_safe_transfer_internal_ransfers_to_invalid_receiver( | |||
fn error_when_safe_transfer_internal_transfers_to_invalid_receiver( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds missing tests to erc721 consecutive mostly associated with erc721 standard's operations.