Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase code coverage at consecutive #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Sep 20, 2024

Adds missing tests to erc721 consecutive mostly associated with erc721 standard's operations.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 4407ec8
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66ed481074a47100087b11b8

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (d5ed376) to head (4407ec8).

Additional details and impacted files
Files with missing lines Coverage Δ
...ntracts/src/token/erc721/extensions/consecutive.rs 91.0% <100.0%> (+28.8%) ⬆️
contracts/src/token/erc721/mod.rs 88.4% <ø> (ø)

@qalisander qalisander marked this pull request as ready for review September 20, 2024 10:09
}

#[motsu::test]
fn error_when_safe_transfer_transfers_from_incorrect_owner(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would skip the naming convention we decided some time ago and leave: error_when_safe_transfers_from_incorrect_owner

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to all tests.

Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment regarding naming convention.

@@ -2306,7 +2306,7 @@ mod tests {
}

#[motsu::test]
fn error_when_safe_transfer_internal_ransfers_to_invalid_receiver(
fn error_when_safe_transfer_internal_transfers_to_invalid_receiver(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants