Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(erc721): add pausable as an independent extension #245

Closed
wants to merge 3 commits into from

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Aug 15, 2024

Current implementation of pausable doesn't need to use selectors with same ID (non unique selectors are expected to banned in future stylus sdk release).
Also there is a less possibility for user to make mistake overriding erc721 transfer-like functions.
The drawback is an additional code duplication from erc721 contract.

PR Checklist

  • Tests
  • Documentation

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit c7da5dd
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66bdb9f2e152e700080f934e

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 52.04082% with 141 lines in your changes missing coverage. Please review.

Project coverage is 82.5%. Comparing base (111b166) to head (c7da5dd).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/token/erc721/extensions/pausable.rs 53.5% 132 Missing ⚠️
contracts/src/token/erc721/mod.rs 0.0% 3 Missing ⚠️
contracts/src/utils/pausable.rs 25.0% 3 Missing ⚠️
contracts/src/utils/structs/checkpoints.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ntracts/src/token/erc721/extensions/consecutive.rs 65.1% <ø> (+0.7%) ⬆️
contracts/src/token/erc721/mod.rs 95.7% <0.0%> (-0.3%) ⬇️
contracts/src/utils/pausable.rs 80.6% <25.0%> (-2.1%) ⬇️
contracts/src/utils/structs/checkpoints.rs 96.5% <0.0%> (-1.1%) ⬇️
contracts/src/token/erc721/extensions/pausable.rs 53.5% <53.5%> (ø)

@qalisander qalisander marked this pull request as ready for review August 15, 2024 11:43
@qalisander qalisander closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant