Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(erc721): implement erc-721 token standard #23

Merged
merged 69 commits into from
Apr 5, 2024
Merged

feat(erc721): implement erc-721 token standard #23

merged 69 commits into from
Apr 5, 2024

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Apr 1, 2024 •
edited by alexfertel
Loading

Resolves #28

PR Checklist

  • Tests
  • Documentation

@qalisander
add prototype for erc721
9557057
@qalisander
split events and errors in sol! macro
3bace8f
@qalisander
restructure same erc721 same as erc20
a551ccf
@qalisander
add arguments to documentation
b732325
@qalisander
add events section to documentation
6cd1d75
@qalisander
add balance test
f797bc7
@qalisander
create Error enum
6a7b2a9
@qalisander
add documentation for error's and event's fields
5bf9e6d
@qalisander
add mint_nft_and_check_balance test
987b2f8
@qalisander
add error_mint_second_nft test
6a7bcc0
@qalisander
add transfer_nft test
903a960
@qalisander
add error_transfer_nonexistent_nft test
c45f61e
@qalisander
add approve_nft_transfer and transfer_approved_nft tests
9bf2d93
@qalisander
add error_not_approved_nft_transfer test
1a19400
@qalisander
prefix internal functions with underscore
55c65a7
@qalisander
remove std deps
ff6716e
@qalisander
fix function and events links in documentation
6cbaf5a
@qalisander
add errors description to documentation
3a360b5
@qalisander
rust fmt
3ece161
@qalisander
add more error documentation
2b0e865
@netlify Netlify
Copy link

netlify bot commented Apr 1, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit b84eed2
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66100521b38aec0008c8af58

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024

The author of this PR, qalisander, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

qalisander
qalisander commented Apr 1, 2024
View reviewed changes
contracts/src/lib.rs Outdated Show resolved Hide resolved
alexfertel
alexfertel suggested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@alexfertel alexfertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking beautiful sir!

I did a first pass, only looking at superficial things, feel free to leave stuff related to comments the same, I can do a separate pass fixing small aesthetic and readability things.

I will do a separate pass looking at the code before Thursday eod, there's a lot to unpack here and I need to get more familiar with it.

Wonderful job so far!

contracts/src/erc721/mod.rs Show resolved Hide resolved
contracts/src/erc721/mod.rs Outdated Show resolved Hide resolved
contracts/src/erc721/mod.rs Outdated Show resolved Hide resolved
contracts/src/erc721/mod.rs Show resolved Hide resolved
contracts/src/erc721/mod.rs Show resolved Hide resolved
contracts/src/erc721/mod.rs Outdated Show resolved Hide resolved
contracts/src/erc721/mod.rs Outdated Show resolved Hide resolved
contracts/src/erc721/mod.rs Outdated Show resolved Hide resolved
contracts/src/erc721/mod.rs Outdated Show resolved Hide resolved
contracts/src/lib.rs Outdated Show resolved Hide resolved
@alexfertel alexfertel added priority: 2 We will resolve this in a short timeframe. type: feature New feature request. labels Apr 2, 2024
@qalisander qalisander merged commit 484dbd9 into main Apr 5, 2024
17 of 18 checks passed
@qalisander qalisander deleted the erc-721 branch April 5, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo left review comments

@alexfertel alexfertel alexfertel approved these changes

@bidzyyys bidzyyys Awaiting requested review from bidzyyys bidzyyys is a code owner

Assignees

@qalisander qalisander

Labels
effort: high Large or difficult task. priority: 2 We will resolve this in a short timeframe. type: feature New feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC-721 base implementation
4 participants
@qalisander @alexfertel @bidzyyys @ericnordelo