Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(erc721): properly handle receiver errors #225

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix(erc721): properly handle receiver errors #225

merged 3 commits into from
Aug 1, 2024

Conversation

alexfertel
Copy link
Contributor

@alexfertel alexfertel commented Aug 1, 2024 •
edited
Loading

Resolves #224

The FIXMEs added in the PR are tracked here.

  • Tests

@alexfertel alexfertel added priority: 2 We will resolve this in a short timeframe. type: bug Something is not working as intended. effort: medium Default level of effort. labels Aug 1, 2024
@alexfertel alexfertel self-assigned this Aug 1, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 04c4148
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66ab6b196d3db5000881a635

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Project coverage is 88.9%. Comparing base (fba80ac) to head (04c4148).

Files Patch % Lines
contracts/src/token/erc721/mod.rs 19.0% 17 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
contracts/src/token/erc721/mod.rs 95.7% <19.0%> (-0.6%) ⬇️

@qalisander
Copy link
Member

The pipeline is still failing

qalisander
qalisander approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

bidzyyys
bidzyyys approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
We need an issue for tracking improvements in Revert extensions for E2E.

@alexfertel
Copy link
Contributor Author

@bidzyyys yeah, it's in the PR description!

@alexfertel alexfertel merged commit e2e643c into main Aug 1, 2024
21 checks passed
@alexfertel alexfertel deleted the alexfertel/fix-erc721-receiver-behaviour branch August 1, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys bidzyyys approved these changes

@qalisander qalisander qalisander approved these changes

Assignees

@alexfertel alexfertel

Labels
effort: medium Default level of effort. priority: 2 We will resolve this in a short timeframe. type: bug Something is not working as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Handle receiver contract reverts in ERC-721
3 participants
@alexfertel @qalisander @bidzyyys