test: expect event to be emitted (#88) #108

bidzyyys · 2024-06-07T07:48:32Z

Resolves #88

netlify · 2024-06-07T07:48:46Z

✅ Deploy Preview for contracts-stylus canceled.

Name	Link
🔨 Latest commit	`08540ed`
🔍 Latest deploy log	https://app.netlify.com/sites/contracts-stylus/deploys/6662f00d9407540008e20bc7

codecov · 2024-06-07T07:52:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.0%. Comparing base (981e9dc) to head (08540ed).
Report is 2 commits behind head on main.

Additional details and impacted files

see 1 file with indirect coverage changes

alexfertel · 2024-06-07T08:33:07Z

lib/e2e/src/assert.rs

Should we maybe rename it to assertions.rs? I'm not sure, I feel like assert.rs is not a good name for this module.

lib/e2e/src/assert.rs

examples/erc721/tests/erc721.rs

alexfertel

Looking super nice, I like this much better!

alexfertel

LGTM! Just a comment about wording. 💯

lib/e2e-proc/src/lib.rs

alexfertel · 2024-06-07T11:29:56Z

lib/e2e/src/lib.rs

 pub use deploy::deploy;
 pub use e2e_proc::test;
 pub use system::{provider, Provider, Signer};
 pub use user::User;
+
+/// This macro provides an easy way for broadcasting the transaction


What do you think of changing the wording like this?

Suggested change

/// This macro provides an easy way for broadcasting the transaction

/// This macro provides a shorthand for broadcasting the transaction

bidzyyys added 2 commits June 6, 2024 20:10

test: impl PartialEq for events in E2E Tests (#88)

caef52d

test: add Emits trait (#88)

14c046a

bidzyyys self-assigned this Jun 7, 2024

bidzyyys linked an issue Jun 7, 2024 that may be closed by this pull request

[Feature]: Abstract away asserting events get emitted in e2e tests #88

Closed

1 task