ERC-4337 & ERC-7579 compliant modular smart accounts #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amxx
force-pushed
the
erc4337/interfaces-and-helpers
branch
from
e7f9dbd
to
a1532d0
Compare
Amxx
commented
Apr 11, 2024
Comment on lines
+22
to
+28
| function _tryUseNonce(address owner, uint256 keyNonce) internal returns (bool) { | ||
| return _tryUseNonce(owner, uint192(keyNonce >> 64), uint64(keyNonce)); | ||
| } | ||
|
|
||
| function _tryUseNonce(address owner, uint192 key, uint64 nonce) internal virtual returns (bool) { | ||
| return _useNonce(owner, key) == nonce; | ||
| } |
There was a problem hiding this comment.
Note: these function are not available in the current Nonces contract. They are usefull if you want to revert with an error that you control (required in ERC-4337 entrypoints)
Co-authored-by: Ernesto García <[email protected]>
…nterfaces-and-helpers
frangio
reviewed
Jul 12, 2024
Amxx
force-pushed
the
erc4337/interfaces-and-helpers
branch
from
63f1767
to
a053a8c
Compare
Amxx
force-pushed
the
erc4337/interfaces-and-helpers
branch
from
a053a8c
to
de032e3
Compare
Amxx
changed the title
Amxx
changed the title
Draft
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LIB-1237
Fixes LIB-1236
Fixes LIB-1231
Fixes LIB-1230
Fixes LIB-1229
Fixes LIB-1228
Fixes LIB-1227
PR Checklist
npx changeset add)