Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom node hash in SimpleMerkleTree #39

Merged
merged 13 commits into from
Mar 4, 2024
Merged

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Feb 26, 2024

Replaces #34
Based on #36

src/simple.ts Outdated Show resolved Hide resolved
@Amxx Amxx mentioned this pull request Feb 26, 2024
8 tasks
Base automatically changed from support-raw-leaves-inheritance to master February 27, 2024 19:57
src/core.ts Outdated Show resolved Hide resolved
src/merkletree.ts Show resolved Hide resolved
src/standard.ts Outdated Show resolved Hide resolved
src/standard.ts Outdated Show resolved Hide resolved
@Amxx Amxx marked this pull request as ready for review February 27, 2024 21:22
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/core.ts Outdated Show resolved Hide resolved
src/merkletree.ts Show resolved Hide resolved
src/simple.ts Outdated Show resolved Hide resolved
@Amxx Amxx force-pushed the feature/custom-node-hash branch from 454db43 to 7ee1181 Compare March 4, 2024 11:03
src/simple.ts Show resolved Hide resolved
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Not merging just in case you disagree with a9ae830. Otherwise please merge

@Amxx Amxx merged commit 29f611e into master Mar 4, 2024
3 checks passed
@Amxx Amxx deleted the feature/custom-node-hash branch March 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants