[ansible/docker] Make sure xhost is installed when not EGLFS

[goldyfruit]

Fix #122

Summary by CodeRabbit

• New Features
  • Added conditional installation tasks for display server utilities across various Linux distributions (Debian, RedHat, Arch, and Suse).
    • Enhanced configurability and support for graphical display installation depending on the specified display server settings.

[coderabbitai]

Warning

Rate limit exceeded

@goldyfruit has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 52 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 95ceb31 and f67d6d1.

Walkthrough

The updates enhance the Ansible playbook for the OVOS installer by adding conditional tasks across various Linux distributions to install necessary display-related packages. These changes ensure that essential utilities are available when a graphical display server is configured, improving the adaptability and functionality of the installation process.

Changes

Files	Change Summary
ansible/roles/ovos_installer/tasks/docker/setup-Arch.yml	New task to install xorg-xhost if ovos_installer_display_server is not "N/A".
ansible/roles/ovos_installer/tasks/docker/setup-Debian.yml	New task to install x11-xserver-utils if ovos_installer_display_server is not "N/A".
ansible/roles/ovos_installer/tasks/docker/setup-RedHat.yml	New task to install xorg-x11-server-utils if ovos_installer_display_server is not "N/A".
ansible/roles/ovos_installer/tasks/docker/setup-Suse.yml	New task to install xhost if ovos_installer_display_server is not "N/A".

Assessment against linked issues

Objective	Addressed	Explanation
Ensure xhost is available on Wayland system (#122)	✅

🐇 In a world of code and hops so bright,
I’ve added xhost, making everything right!
With packages for display, oh what a delight,
Now Wayland can flourish, from morning till night.
So let’s celebrate changes, let them take flight! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 45836e4 and 95ceb31.

Files selected for processing (4)

• ansible/roles/ovos_installer/tasks/docker/setup-Arch.yml (1 hunks)
• ansible/roles/ovos_installer/tasks/docker/setup-Debian.yml (1 hunks)
• ansible/roles/ovos_installer/tasks/docker/setup-RedHat.yml (1 hunks)
• ansible/roles/ovos_installer/tasks/docker/setup-Suse.yml (1 hunks)

Additional comments not posted (5)

ansible/roles/ovos_installer/tasks/docker/setup-Arch.yml (1)

9-12: Ensure the condition for installing xorg-xhost is appropriate.

The new task to install xorg-xhost is conditionally executed based on the ovos_installer_display_server variable. Verify that this variable is correctly set in all relevant scenarios.

ansible/roles/ovos_installer/tasks/docker/setup-Suse.yml (1)

15-18: Ensure the condition for installing xhost is appropriate.

The new task to install xhost is conditionally executed based on the ovos_installer_display_server variable. Verify that this variable is correctly set in all relevant scenarios.

ansible/roles/ovos_installer/tasks/docker/setup-RedHat.yml (1)

21-24: Ensure the condition for installing xorg-x11-server-utils is appropriate.

The new task to install xorg-x11-server-utils is conditionally executed based on the ovos_installer_display_server variable. Verify that this variable is correctly set in all relevant scenarios.

ansible/roles/ovos_installer/tasks/docker/setup-Debian.yml (2)

47-51: Verify the condition for installing x11-xserver-utils.

Ensure that the condition ovos_installer_display_server != "N/A" accurately covers all scenarios where xhost is required. If there are other conditions or values that should trigger the installation, they should be included.

---

48-48: Confirm the usage of community.general.apt.

The task uses the community.general.apt module. Ensure that this module is available and compatible with the target systems. If ansible.builtin.apt can be used instead, it might be preferable for consistency.