Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run t_server_null.sh tests with release/2.5 and release/2.6 clients #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattock
Copy link
Member

@mattock mattock commented Oct 17, 2024

This has been implemented as a special buildbot worker coupled with a customized t_server_null.rc file. That special buildbot worker container image should be rebuilt periodically to ensure we're not using outdated client code.

This has been implemented as a special buildbot worker coupled with a
customized t_server_null.rc file. That special buildbot worker container image
should be rebuilt periodically to ensure we're not using outdated client code.

Signed-off-by: Samuli Seppänen <[email protected]>
@mattock
Copy link
Member Author

mattock commented Oct 17, 2024

The choice of Debian 12 the "legacy" buildbot worker was purely arbitrary.

Also: I'll look into a reasonable mechanism for rebuilding the image periodically. I'm thinking of using systemd timers as they allow building after boot and then in regular intervals. That said, a cronjob would be good enough as well.

@mattock
Copy link
Member Author

mattock commented Oct 17, 2024

This systemd timer and service combination seems to do the trick:

$ cat /etc/systemd/system/rebuild-buildbot-worker-debian-12-legacy.timer
[Unit]
Description=Rebuild buildbot-worker-debian-12-legacy Docker container image

[Timer]
OnBootSec=1m
OnUnitActiveSec=1w

[Install]
WantedBy=timers.target

$ cat /etc/systemd/system/rebuild-buildbot-worker-debian-12-legacy.service
[Unit]
Description=Rebuild buildbot-worker-debian-12-legacy

[Service]
Type=oneshot
RemainAfterExit=no
ExecStart=/bin/bash -c "cd /root/openvpn-buildbot/buildbot-host && ./rebuild.sh buildbot-worker-debian-12-openvpn-legacy"

Copy link

@uddr uddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattock
Copy link
Member Author

mattock commented Oct 23, 2024

@flichtenheld looks ok to you as well? This should be easily testable on the community buildbot despite the Ubuntu version differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants