Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release prep #4

Merged
merged 27 commits into from
Jan 30, 2024
Merged

Release prep #4

merged 27 commits into from
Jan 30, 2024

Conversation

apetrynet
Copy link
Member

@apetrynet apetrynet commented Oct 20, 2023 •
edited
Loading

Preparing the ALE adapter repo for release of OpenTimelineIO 0.17.0 that ships without adapters

Feedback is welcome

@apetrynet
- Updated targeted OTIO version.
adedb16 
- Removed build against "extract_adapters" branch
- Removed exclusion of python and otio version

Signed-off-by: apetrynet <[email protected]>
@apetrynet
Removed as it doesn't fit our release procedures
5952a82 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
Added missing python version
90a3bc6 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
- Added badges
56b5ac2 
- Added documentation on additional arguments

Signed-off-by: apetrynet <[email protected]>
@apetrynet
Upped the dependency OTIO version
b601884 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
Set otio version to 0.17.0.dev1 as it should cover both dev releases …
6c8a7e0 
…and final release when we get there.

Signed-off-by: apetrynet <[email protected]>
@apetrynet
Added cmake to list of dependencies
11a56b0 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
updated python gha version
413ae90 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
Copy link
Member Author

@JeanChristopheMorinPerso Do you have any theory on why the windows test fails for python 3.11?

@JeanChristopheMorinPerso
Copy link
Member

It looks like a long path issue:

FileTracker : error FTK1011: could not create the new file tracking log file: C:\Users\runneradmin\AppData\Local\Temp\pip-install-j1at8w0p\opentimelineio_ae509fc301cc4e90a4e093bb32c048af\build\temp.win-amd64-cpython-311\Release\tmpah35su62\CMakeFiles\CMakeScratch\TryCompile-yb20yr\cmTC_4ff8e.dir\Debug\cmTC_4ff8e.tlog\link-rc.read.1.tlog. The system cannot find the path specified. [C:\Users\runneradmin\AppData\Local\Temp\pip-install-j1at8w0p\opentimelineio_ae509fc301cc4e90a4e093bb32c048af\build\temp.win-amd64-cpython-311\Release\tmpah35su62\CMakeFiles\CMakeScratch\TryCompile-yb20yr\cmTC_4ff8e.vcxproj]

@JeanChristopheMorinPerso
Copy link
Member

@apetrynet can you try to add a little debugging step?

- name: Check LongPathsEnabled
  run: |
     (Get-ItemProperty "HKLM:System\CurrentControlSet\Control\FileSystem").LongPathsEnabled

This will tell us if the long path mode is enabled or not.

@JeanChristopheMorinPerso
Fix CI
7d99477 
Signed-off-by: Jean-Christophe Morin <[email protected]>
@apetrynet apetrynet marked this pull request as ready for review November 9, 2023 13:14
@apetrynet
Changed order of badges
d1c598b 
Signed-off-by: apetrynet <[email protected]>
@apetrynet apetrynet merged commit a661a0c into OpenTimelineIO:main Jan 30, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanChristopheMorinPerso JeanChristopheMorinPerso JeanChristopheMorinPerso approved these changes

@reinecke reinecke Awaiting requested review from reinecke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apetrynet @JeanChristopheMorinPerso