Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typescript from 5.4.5 to 5.6.2 in /front-end #54

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps typescript from 5.4.5 to 5.6.2.

Release notes

Sourced from typescript's releases.

TypeScript 5.6

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.6 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.6 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

... (truncated)

Commits
  • a7e3374 Bump version to 5.6.2 and LKG
  • 2063357 🤖 Pick PR #59708 (LEGO: Pull request from lego/hb_537...) into release-5.6 (#...
  • 4fe7e41 🤖 Pick PR #59670 (fix(59649): ts Move to a new file d...) into release-5.6 (#...
  • 1a03e53 🤖 Pick PR #59761 (this can be nullish) into release-5.6 (#59762)
  • 6212132 Update LKG
  • bbb5faf 🤖 Pick PR #59542 (Fixing delay caused in vscode due t...) into release-5.6 (#...
  • e6914a5 Bump version to 5.6.1-rc and LKG
  • 34121c4 Update LKG
  • 2a30c2a Merge remote-tracking branch 'origin/main' into release-5.6
  • 936a79b Expose TypeChecker. getAwaitedType to public (#59268)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 9, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch 6 times, most recently from a0a57cb to 8f5be7a Compare September 15, 2024 20:18
@reefdog
Copy link
Collaborator

reefdog commented Sep 15, 2024

@hminsky2002 When I npm i this branch and then npm run lint, I get this warning as part of the output:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Please only submit bug reports when using the officially supported version.

=============

What do you think? Should we wait for @typescript-eslint/typescript-estree to be updated before merging this in, or ignore that warning?

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch from 8f5be7a to 7fa2350 Compare September 15, 2024 23:59
@hminsky2002
Copy link
Collaborator

@hminsky2002 When I npm i this branch and then npm run lint, I get this warning as part of the output:

=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0
YOUR TYPESCRIPT VERSION: 5.6.2
Please only submit bug reports when using the officially supported version.

What do you think? Should we wait for @typescript-eslint/typescript-estree to be updated before merging this in, or ignore that warning?

I think I'd prefer to wait for this update until it's officially supported, since we don't currently have any dependencies on typescript 5.6+. However, I don't love limiting our typescript updates to a single package. I'll need to think it over a bit more, do you have an inclination one way or the other?

@reefdog
Copy link
Collaborator

reefdog commented Sep 17, 2024

@hminsky2002 I failed to respond to the above, but: I agree with not updating while this warning persists. If it starts to really hold us back, we'll reevaluate.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch 3 times, most recently from 86338ad to a90c82e Compare September 24, 2024 22:24
@reefdog reefdog marked this pull request as draft September 24, 2024 22:29
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch 4 times, most recently from 5a5c3ce to de0a02f Compare September 24, 2024 22:40
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch from de0a02f to f1aa8df Compare October 2, 2024 10:07
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.4.5 to 5.6.2.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.4.5...v5.6.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch from f1aa8df to c3c7e02 Compare October 3, 2024 07:21
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 14, 2024

Superseded by #144.

@dependabot dependabot bot closed this Oct 14, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/front-end/typescript-5.6.2 branch October 14, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants