Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Add-on Input Mode Selection Slider #448

Closed

Conversation

HoboDev
Copy link
Contributor

@HoboDev HoboDev commented Aug 7, 2023

Allows up to 3 modes to be selected with a slider.

@TheTrainGoes
Copy link
Contributor

This is neat!

I am getting fairly frequent lockups on my unit if I slide too quickly. Any idea what might be causing that?

@HoboDev
Copy link
Contributor Author

HoboDev commented Aug 11, 2023

I've experienced that the display locks up but not the unit itself. How is it in your case?
I don't really know what's causing it but for me everything works fine at the current waiting time. (But I don't have a slider, only buttons)
I can recommend to increase the waiting time after disconnect from 1000ms. But it might also help to increase the debouncing time instead. I've set it to 50 to accommodate sliding multiple positions. How many positions do you slide when this happens?

There is also a resulting nuisance: When rebooting the splash screen will be shown (if active) but the statusbar will show the change immediately. So I was thinking to create a loading animation to distract the user.

@TheTrainGoes
Copy link
Contributor

@HoboDev just to add to this you are correct - it is just the screen and LEDs that are freezing. Still an issue but not as bad.

Animations would be good in any case :)

@bsstephan
Copy link
Contributor

@TheTrainGoes or @HoboDev - when the freeze occurs, do any of the addons still work? I wonder if somehow core1 is deadlocking.

@HoboDev
Copy link
Contributor Author

HoboDev commented Aug 14, 2023

One more question. Is the freeze temporary like the result of the 600ms waiting time? Or does the screen lock up until forcefully rebooting?

I'll have to hook up some leds to my testing rig (with is just a pico, a display and two buttons) then I can think about a solution. Maybe instead of letting the controller sleep I'll use a non-blocking option. I just copied the player led add-on in that regard.

@TheTrainGoes
Copy link
Contributor

Apologies @HoboDev I have been very bust with recent releases.

Will circle back to this next week when I can.

@arntsonl
Copy link
Contributor

Functionality wise, this is something we already support with a reboot + holding B1-B4. With the addition of a Fn key reboot shortcut, I'm going to close this PR.

For code clean-ups and cleanliness, feel free to add another PR. Also feel free to chat with us on Discord for ideas and feedback!

@arntsonl arntsonl closed this Aug 16, 2023
@HoboDev
Copy link
Contributor Author

HoboDev commented Aug 22, 2023

Well on Discord someone encouraged the PR after I was talking about a feature like this.

While the SOCD mode can be changed with a slider and hotkeys it's current setting can be verified quite easily compared to the input mode. (Except when using a display and maybe some other means I don't know about)

@TheTrainGoes Whenever you're ready let me know. I've been busy as well putting together a prototype version of my controller with LEDs. So I can investigate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants