-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Add-on Input Mode Selection Slider #448
ADD: Add-on Input Mode Selection Slider #448
Conversation
This is neat! I am getting fairly frequent lockups on my unit if I slide too quickly. Any idea what might be causing that? |
I've experienced that the display locks up but not the unit itself. How is it in your case? There is also a resulting nuisance: When rebooting the splash screen will be shown (if active) but the statusbar will show the change immediately. So I was thinking to create a loading animation to distract the user. |
@HoboDev just to add to this you are correct - it is just the screen and LEDs that are freezing. Still an issue but not as bad. Animations would be good in any case :) |
@TheTrainGoes or @HoboDev - when the freeze occurs, do any of the addons still work? I wonder if somehow core1 is deadlocking. |
One more question. Is the freeze temporary like the result of the 600ms waiting time? Or does the screen lock up until forcefully rebooting? I'll have to hook up some leds to my testing rig (with is just a pico, a display and two buttons) then I can think about a solution. Maybe instead of letting the controller sleep I'll use a non-blocking option. I just copied the player led add-on in that regard. |
Apologies @HoboDev I have been very bust with recent releases. Will circle back to this next week when I can. |
Functionality wise, this is something we already support with a reboot + holding B1-B4. With the addition of a Fn key reboot shortcut, I'm going to close this PR. For code clean-ups and cleanliness, feel free to add another PR. Also feel free to chat with us on Discord for ideas and feedback! |
Well on Discord someone encouraged the PR after I was talking about a feature like this. While the SOCD mode can be changed with a slider and hotkeys it's current setting can be verified quite easily compared to the input mode. (Except when using a display and maybe some other means I don't know about) @TheTrainGoes Whenever you're ready let me know. I've been busy as well putting together a prototype version of my controller with LEDs. So I can investigate the issue. |
Allows up to 3 modes to be selected with a slider.