Fix keyboard host mapping #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've flashed my Waveshare board with this build and set the appropriate data pins so that the Keyboard Host Addon is working with a keyboard plugged into the host port. The action buttons were fixed so that the labels match the proper input. However, with the function buttons A2 and S1 are reversed and require assignments for the other to work properly. Example:Desired Inputs and Intended Mapping
Necessary mapping to get above
|
|
This is a different issue unrelated to the Keyboard Host addon. The labels get swapped incorrectly. I've pushed fixes for these. |
|
This does resolve the issues I was having initially with the PR |
arntsonl
approved these changes
Aug 3, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #395.
Thanks to @InfraredAces for thorough testing and a very descriptive writeup about the issue!
The fix is very simple and a mistake from my side, sorry for that.
Edit: The addon has been enabled for testing purpose. It can be disabled if there are difficulties in making the merge.
Please check and merge, thanks!