Ability to switch between action/direction button profiles #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsstephan
force-pushed
the
multiple-button-profiles
branch
from
c824603
to
31a0021
Compare
|
When refreshing the page another request gets trigger and sets When navigating from another route the other request that set loading to false has already happen, now the only request that gets trigger is In essence this is because we are using one property When the time present itself i'll rewrite the state handling loading. |
Pelsin
reviewed
Jul 4, 2023
bsstephan
force-pushed
the
multiple-button-profiles
branch
from
84e4111
to
417519e
Compare
bsstephan
changed the title
bsstephan
force-pushed
the
multiple-button-profiles
branch
3 times, most recently
from
e94e13b
to
3dd73e4
Compare
bsstephan
force-pushed
the
multiple-button-profiles
branch
from
3dd73e4
to
66dd027
Compare
mthiesen
previously requested changes
Jul 19, 2023
bsstephan
force-pushed
the
multiple-button-profiles
branch
from
66dd027
to
1246d87
Compare
bsstephan
changed the title
up to three alternative pin mappings can be defined to profiles 2-4 (1 is the primary setting) which overlay their mappings on top of the primary settings. this also defines four hotkey actions for switching between the four profiles. all pre-profile configuration works the same and affects the same config objects, etc. as before. a new configuration page and config memory section is defined for profiles 2-4 (specifically the alternative pin mappings). profiles 2-4 default to the board mappings, as well, so users should be fine to ignore this feature entirely if they want --- normal function should not changed, and they shouldn't even be able to accidentally enable this, especially not into a broken configuration
bsstephan
force-pushed
the
multiple-button-profiles
branch
from
1246d87
to
7ef1962
Compare
|
Issues were fixed, there is one new issue that we'll make a Issue# for but might be related to react. |
arntsonl
dismissed
mthiesen’s stale review
Changes fixed issue, not sure how to "Resolve" someone else's request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working: