remove the JS Slider addon, move it to core #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this removes a bunch of code to support the addon, naturally, but the idea is the same, just in core. of note, the default mode when no slider pins are active has been folded into the core gamepad setting, so a tiny migration copies the user's default mode into the gamepad setting in order to not violate expectations. the user can still change this setting there via webconfig or hotkeys. this also updates the DDI addon to get the active mode (rather than the settings mode) so that it doesn't do weird cleaning and/or override things, and updates the display code to show the active mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes a bunch of code to support the addon, naturally, but the idea is the same, just in core. of note, the default mode when no slider pins are active has been folded into the core gamepad setting, so a tiny migration copies the user's default mode into the gamepad setting in order to not violate expectations. the user can still change this setting there via webconfig or hotkeys.
this also updates the DDI addon to get the active mode (rather than the settings mode) so that it doesn't do weird cleaning and/or override things, and updates the display code to show the active mode.
closes #941