Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575 #576

Open
wants to merge 7 commits into
base: Cog
Choose a base branch
from

Conversation

KenDickey
Copy link
Contributor

Fix for bug:

Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575

Tested on arm32 Raspberry Pi 3 with Raspberry Pi OS (no X11)
and on arm64 Le Potato (AML-S905S-XX) with Armbian OS.

Nota Bene: The include file ordering fix for arm64 does not seem to have been applied yet to the 32 bit platform.

@KenDickey
Copy link
Contributor Author

Notes:
[A] Given the superannuated nature of the code, it would be good to eliminate the ps2 mouse support and invert the logic so that the -DUSEEVDEV guard was inverted so as to make this code path the default code. Then this flag would no longer be required by the normal build. IMHO, this would be less confusing.

[B] The display_printUsage() help text options really need to be more thoroughly tested, e.g. by people using non-us keyboards.

@eliotmiranda
Copy link
Contributor

eliotmiranda commented Jul 27, 2021 via email

@KenDickey
Copy link
Contributor Author

KenDickey commented Jul 28, 2021

Elided USEEVDEV flag & fixes a few nits.
Tested mvm's & working on:
Aarch64/arm64 [LePotato/Armbian]
squeak.cog.spur/build
squeak.cog.spur/build.debug
squeak.stack.spur/build
Arm32 [RPi3/Raspberry Pi OS]
squeak.cog.spur/build
squeak.cog.spur/build.debug

Looks ready to integrate..

hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 25, 2021
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 25, 2021
hogoww referenced this pull request in hogoww/opensmalltalk-vm Feb 26, 2022
… method [ attemptToShrink ] 10 test cases.
hogoww referenced this pull request in hogoww/opensmalltalk-vm Feb 26, 2022
…method [ attemptToShrink ] 8/10 Test Cases are NOT EQUIVALENT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants