Fix mutex locking in _pkcs11h_threading_cond{Init,Wait} functions. #65
Conversation
| rv = CKR_FUNCTION_FAILED; | ||
| goto cleanup; | ||
| } | ||
| unlock_mutex = 1; |
There was a problem hiding this comment.
this should wait not fail if other holds the lock, can it be done?
There was a problem hiding this comment.
We could spin in a loop calling pthread_mutex_trylock until times passes out. But this is basically a spinlock.
Not sure if this is a good idea.
There was a problem hiding this comment.
as far as I remember this was my initial use of cond as mutex cannot wait... yes, spin loop is bad, there must be a different solution, otherwise the pthread_cond_timedwait has little sense.
There was a problem hiding this comment.
If the mutex is only used for waiting on the condition variable, the amount of time it is locked should be really short. Maybe spinlock here is actually OK.
Anyways, this change doesn't make the code any worse than it was.
|
Hi, |
|
Let's just remove the "Sponsored by" tag, then. |
|
please sign-off so we have no future issues, trivial issues I accept without. |
According to pthread_cond_wait manpage, the mutex has to be locked by the same thread that is going to call pthread_cond_wait afterwards. This was not true before this change and was causing test-slotevent to busy-loop on FreeBSD. Signed-off-by: Gleb Popov <[email protected]>
|
Thank you, merged with some minor changes. |
According to pthread_cond_wait manpage, the mutex has to be locked by the same thread that is going to call pthread_cond_wait afterwards. This was not true before this change and was causing test-slotevent to busy-loop on FreeBSD.