-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add net8.0 and efcore 8.0 #475
Conversation
* Asp Core * New extension method to add OpenRiaServices to services. * New extension method to add OpenRiaServices to pipeline. --------- Co-authored-by: SandstromErik <[email protected]>
Adding links to CoC and .NET Foundation website
" load mono.cecil.pdb from same folder as tools Fix to prevent #247 from happening again
… csproj (#411) * update targets file * Add .NET foundation
Revert entityframework update from 6.* to 7.* Update entityframwork nugets from 3.1.24 to 3.1.32
Remove * for entityframework nuget
* Add Net7 build target to support "Finally Conventions" (IEndpointConventionBuilder.Finally) * Add OpenRiaServices.Server.DomainOperationEntry to endpoint metadata This allows end user to easier implement additional conventions (such as Open Api or similar) * Copy AuthorizationAttributes to endpoint metadata for queries and invokes to support AspNetCore Authorization Attributes can be set on either method or class level
Modify the next size to rent for buffer in ArrayPoolStream in order to handle large buffers
Update Changelog for release
* Update changelog
* Asp Core * New extension method to add OpenRiaServices to services. * New extension method to add OpenRiaServices to pipeline. --------- Co-authored-by: SandstromErik <[email protected]>
Adding links to CoC and .NET Foundation website
" load mono.cecil.pdb from same folder as tools Fix to prevent #247 from happening again
… csproj (#411) * update targets file * Add .NET foundation
Revert entityframework update from 6.* to 7.* Update entityframwork nugets from 3.1.24 to 3.1.32
Remove * for entityframework nuget
Modify the next size to rent for buffer in ArrayPoolStream in order to handle large buffers
Update Changelog for release
* Update changelog
Revert entityframework update from 6.* to 7.* Update entityframwork nugets from 3.1.24 to 3.1.32
@dotnet-policy-service agree
dotnet-policy-service[bot] ***@***.***> در تاریخ
یکشنبه ۷ ژانویه ۲۰۲۴ ساعت ۱۷:۴۲ نوشت:
… @ehsangfl <https://github.com/ehsangfl> please read the following
Contributor License Agreement(CLA). If you agree with the CLA, please reply
with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:
- (default - no company specified) I have sole ownership of
intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.
@dotnet-policy-service agree
- (when company given) I am making Submissions in the course of work
for my employer (or my employer has intellectual property rights in my
Submissions by contract or applicable law). I have permission from my
employer to make Submissions and enter into this Agreement on behalf of my
employer. By signing below, the defined term “You” includes me and my
employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement Contribution License Agreement
This Contribution License Agreement ( *“Agreement”* ) is agreed to by the
party signing below ( *“You”* ),
and conveys certain license rights to the .NET Foundation ( *“.NET
Foundation”* ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of
the latest signature date below.
*1. Definitions.*
*“Code”* means the computer software code, whether in human-readable or
machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.
*“Project”* means any of the projects owned or managed by .NET Foundation
and offered under a license
approved by the Open Source Initiative (www.opensource.org).
*“Submit”* is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic mailing
lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of,
the Project for the purpose of
discussing and improving that Project, but excluding communication that is
conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
*“Submission”* means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
*2. Your Submission.* You must agree to the terms of this Agreement
before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in
the future (except as
described in Section 4 below), Submit to any Project.
*3. Originality of Work.* You represent that each of Your Submissions is
entirely Your
original work. Should You wish to Submit materials that are not Your
original work,
You may Submit them separately to the Project if You (a) retain all
copyright and
license information that was in the materials as you received them, (b) in
the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third
party and any
licenses or other restrictions of which You are aware, and (c) follow any
other
instructions in the Project's written guidelines concerning Submissions.
*4. Your Employer.* References to “employer” in this Agreement include
Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor,
vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You must
secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change
employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
*5. Licenses.*
*a. Copyright License.* You grant .NET Foundation, and those who receive
the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of,
publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense
any or all of the foregoing
rights to third parties.
*b. Patent License.* You grant .NET Foundation, and those who receive the
Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission
or the combination of the
Submission with the Project to which it was Submitted to make, have made,
use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
*c. Other Rights Reserved.* Each party reserves all rights not expressly
granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
*6. Representations and Warranties.* You represent that You are legally
entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3 ). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the course
of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You
choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER
THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY
WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
*7. Notice to .NET Foundation.* You agree to notify .NET Foundation in
writing of any facts or
circumstances of which You later become aware that would make Your
representations in this
Agreement inaccurate in any respect.
*8. Information about Submissions.* You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
*9. Governing Law/Jurisdiction.* This Agreement is governed by the laws
of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which
case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
*10. Entire Agreement/Assignment.* This Agreement is the entire agreement
between the parties, and
supersedes any and all prior agreements, understandings or communications,
written or oral, between
the parties relating to the subject matter hereof. This Agreement may be
assigned by .NET Foundation.
*.NET Foundation dedicates this Contribution License Agreement to the
public domain according to the Creative Commons CC0 1.*
—
Reply to this email directly, view it on GitHub
<#475 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQ6VRNKGLH7VUSXRRIDE73YNKUNJAVCNFSM6AAAAABBQLI3U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGA3TCMJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@ehsangfl it looks like you got more commits and changes than expected. Can you rebase or create a new branch based on current main with just the commits for efcore 8 support? @SandstromErik do you have the time to look at this after cleanup? Once the changes are in we need to update the version property in the .csproj. We can consider dropping .net6/efcore6 support but it is a bit easier said than done since it is referenced from test projects targeting net6 at the moment. (We can either update test projects or compile net6 but exclude it from nuget package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no problems and have no other comments to these changes
* Update Changelog.md
…n't need to install System.Collections.Immutable (#479)
* Use portable pdbs for framework targets * fix expected / actual order in Assert.AreEqual * Remove creation of ProjectPath.txt from some projects that dont need it
* update mstest nuget packages to 3.2 * <Reference should only be included for NET Framework
Makes adding n entities to an EntityCollection or similar roughly O(n) instead of O(n²) * Don't further process entities which are New, Unchanged, Modified since any changes to them would have already been discovered * Calculate and cache AssociationMembers once * Do some code/style cleanup which might also give marginally better perf (calls contains on HashSet instead of Enumerable) and smarter enum checks due to pattern matchning * Always package nuget's so that PR artifacts can be tested * minor EntitySet perf improvements * Use result of HashSet.Add instead of checking Contains before Add * Make ListCollectionViewProxy smarter * remove IndexOf from Add for O(1) instead of O(n) performance * Contains use hashSet contains instead of IndeOf for O(1) instead of O(n) performance * Remove argument range check * EntitySet Make _set and _identityCache fields readonly
Remove unnecessary calls to *.Contains() * Combine .!Contains with .Add into a single Add operation * Replace IndexOf with Contains (faster remove from EntityCollection) Go though usages of ContainsKey * Use TryAdd instead if followed by Add * Use TryGet if followed by fetching value * Switch to HashSet if value is not used Replace unneccesary IndexOf calls * When access EntitySet of EntityCollection using CollectioViewSource add and Contains checks are much faster O(1) instead of O(n) This translates to roughly ~9% perf improvement for adding 50 000 entities to an EntityCollection.
This fixes the current analyser suggestions/warnings when building AspNetCore hosting about several places in query deserialisation where span's should be used instead of substring. Performance and allocations might be better, but the main driver is to remove build output when building the AspNetCore hosting project. Apart from that it also changes naming of private fields to better match the rest of the code base * Add System.Collections.Immutable nuget dependency to WCF Hosting and update other dependencies
@ehsangfl thank you for the contribution. I will probably create a new PR with just the required change to the efcore project and will try to add you as co-author Some recommendations for you :
|
…ttributes. Also removed unneccesary attribute sorting and updated most tt generated files (#495)
No description provided.