Add new test that validate how object level validation interact with property level validation #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Test/OpenRiaservices.EndToEnd.Wcf.Test/Data/EntityValidationTests.cs
Fixed
Show fixed
Hide fixed
|
Kudos, SonarCloud Quality Gate passed! |
|
@SandstromErik/ @erikoijwall please merge if you think this is a good solution and the test seems OK. I have validated that the test passed against 5.4.0, but failed in main without the fix here. Normally object validation is triggered when submitting changes as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a change that #453 changed behaviour for properties which are only validated using object level validation (either IValidatableObject or Validation attributes on the type) but does not have any property level validation attributes.
Previously such object level validation errors where cleared when if the property was modified.