Fix .NET7+ code generation crash for RegularExpressionAttribute #449

Daniel-Svensson · 2023-10-25T18:05:55Z

Don't try to copy over MatchTimeout attribute to client (it has no setter)
Log whole exception (hopefully with stack trace on error)

One reason that this was a problem is that the attribute does not have a ctor with no parameters so the code to figure out default property values is "broken".
These types of properties should not be a problem if it would be fixed.

This specific issue seems to only happen when running on .net7 so we should make sure that code generation tests run on net7 (and net8 as well) to be sure that things work as expected

Daniel-Svensson · 2023-10-29T20:40:12Z

@SandstromErik have you already solved this issue (and potentially others) in your .NET 8 branch or should we merge this ?

SandstromErik · 2023-10-30T08:20:45Z

@SandstromErik have you already solved this issue (and potentially others) in your .NET 8 branch or should we merge this ?

@Daniel-Svensson Yes I ran into the same problem and I have made the same fix in my .Net 8 branch so it is not necessary but we might aswell merge this now since that branch is not ready yet

…ding non existing assemblies)

Daniel-Svensson · 2023-10-31T09:22:57Z

@SandstromErik there is still a tools test failing with .net7 so I had to remove thee target framework again (something with different versions of system.runtime when compiling code).

If you have fixes for this I think it would be a good idea to create a PR with your different code fixes which might make sense for .net7 and enable the codegen tests to run on .net7 in a first step.