Speed up ValidateProperty (#453)

* Check metaMember.IsComplex before casting to ComplexObject * Only do validation if property requires validation (don't check whole object)
OpenRIAServices · Oct 31, 2023 · d6fe496 · d6fe496
1 parent 89119c4
commit d6fe496
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/OpenRiaServices.Client/Framework/Entity.cs b/src/OpenRiaServices.Client/Framework/Entity.cs
@@ -1298,13 +1298,12 @@ protected void ValidateProperty(string propertyName, object value)
                 throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, Resource.Property_Is_ReadOnly, propertyName));
             }
 
-            ComplexObject complexObject = value as ComplexObject;
-            if (complexObject != null && complexObject.IsAttached)
+            if (metaMember.IsComplex && value is ComplexObject complexObject && complexObject.IsAttached)
             {
                 throw new InvalidOperationException(Resource.ComplexType_InstancesCannotBeShared);
             }
 
-            if (this.MetaType.RequiresValidation)
+            if (metaMember.RequiresValidation)
             {
                 ValidationContext validationContext = this.CreateValidationContext();
                 validationContext.MemberName = propertyName;